UI: Disable the options of unselected exploiters #2855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 64.91% // Head: 64.91% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## develop #2855 +/- ##
========================================
Coverage 64.91% 64.91%
========================================
Files 415 415
Lines 11804 11804
========================================
Hits 7663 7663
Misses 4141 4141 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ilija-lazoroski
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2700
Disables the options for unselected exploiters
Minor renaming in PluginSelectorTemplate
The solution is quite messy. I've tried to modify the UiSchema before passing it down to the children, but that seems to not be supported: rjsf-team/react-jsonschema-form#1589
It's possible to do it with CSS, but in that case we would need to style all possible option elements, like inputs, buttons, checkboxes, selects, etc.
PR Checklist
Testing Checklist