Skip to content

2565 remove island ip addressess endpoint #2571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 10, 2022
Merged

2565 remove island ip addressess endpoint #2571

merged 4 commits into from
Nov 10, 2022

Conversation

ilija-lazoroski
Copy link
Contributor

What does this PR do?

Fixes #2565.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by running island locally and checking RunMonkeyPage
    For AWS I tweak the UI a bit just to check if the IPs are correct

  • If applicable, add screenshots or log transcripts of the feature working

image

image

@codecov
Copy link

codecov bot commented Nov 10, 2022 •
edited
Loading

Codecov Report

Base: 62.61% // Head: 62.58% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (a643a62) compared to base (36c0471).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2571      +/-   ##
===========================================
- Coverage    62.61%   62.58%   -0.03%     
===========================================
  Files          350      349       -1     
  Lines        10709    10697      -12     
===========================================
- Hits          6705     6695      -10     
+ Misses        4004     4002       -2
Impacted Files Coverage Δ
monkey/monkey/monkey_island/cc/app.py 75.65% <0.00%> (-0.21%) ⬇️
.../monkey/monkey_island/cc/resources/ip_addresses.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

cakekoa
cakekoa reviewed Nov 10, 2022
View reviewed changes
@ilija-lazoroski ilija-lazoroski force-pushed the 2565-remove-island-ip-addressess-endpoint branch from 9fd687c to f3f4f90 Compare November 10, 2022 16:32
mssalvatore
mssalvatore requested changes Nov 10, 2022
View reviewed changes
mssalvatore
mssalvatore requested changes Nov 10, 2022
View reviewed changes
@ilija-lazoroski ilija-lazoroski force-pushed the 2565-remove-island-ip-addressess-endpoint branch from f3f4f90 to a643a62 Compare November 10, 2022 16:48
@mssalvatore mssalvatore merged commit c6a8354 into develop Nov 10, 2022
@mssalvatore mssalvatore deleted the 2565-remove-island-ip-addressess-endpoint branch November 10, 2022 17:05
@snyk-bot snyk-bot mentioned this pull request Nov 20, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mssalvatore mssalvatore mssalvatore approved these changes

@VakarisZ VakarisZ Awaiting requested review from VakarisZ

@shreyamalviya shreyamalviya Awaiting requested review from shreyamalviya

@cakekoa cakekoa Awaiting requested review from cakekoa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove /api/island/ip-addresses
3 participants
@ilija-lazoroski @cakekoa @mssalvatore