Skip to content

2430 use mapnode #2462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Oct 19, 2022
Merged

2430 use mapnode #2462

merged 19 commits into from
Oct 19, 2022

Conversation

cakekoa
Copy link
Contributor

@cakekoa cakekoa commented Oct 19, 2022

What does this PR do?

Fixes part of #2430.

Updates the preview pane with details from the MapNode structure.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by running the UI in the zoo environment

  • If applicable, add screenshots or log transcripts of the feature working

Base automatically changed from 2334-draw-map-using-new-api to develop October 19, 2022 17:48
mssalvatore
mssalvatore reviewed Oct 19, 2022
View reviewed changes
monkey/monkey_island/cc/ui/src/components/ui-components/LogDownloadButtons.tsx Outdated
timestamp = timestamp.substr(0, timestamp.indexOf('.'));
let filename = res['monkey_label'].split(':').join('-') + ' - ' + timestamp + '.log';
let logContent = unescapeLog(res['log']);
let logContent = unescapeLog(res);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need to do this?

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Base: 60.98% // Head: 60.98% // No change to project coverage 👍

Coverage data is based on head (fb0ce96) compared to base (2d6163c).
Patch has no changes to coverable lines.

❗ Current head fb0ce96 differs from pull request most recent head 94c4127. Consider uploading reports for the commit 94c4127 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #2462   +/-   ##
========================================
  Coverage    60.98%   60.98%           
========================================
  Files          547      547           
  Lines        14502    14502           
========================================
  Hits          8844     8844           
  Misses        5658     5658

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mssalvatore mssalvatore merged commit 160e6e5 into develop Oct 19, 2022
@mssalvatore mssalvatore deleted the 2430-use-mapnode branch October 19, 2022 18:09
@shreyamalviya shreyamalviya mentioned this pull request Feb 2, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mssalvatore mssalvatore mssalvatore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cakekoa @mssalvatore @shreyamalviya