Skip to content

Do actually hydrate islands according to their priority... #9035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 5, 2023
Merged

Do actually hydrate islands according to their priority... #9035

merged 2 commits into from
Oct 5, 2023

Conversation

sndrs
Copy link
Member

@sndrs sndrs commented Oct 5, 2023

actually apply priorities when hydrating islands!

updates #9021

@sndrs sndrs requested a review from a team October 5, 2023 14:30
@sndrs sndrs requested a review from a team as a code owner October 5, 2023 14:30
@sndrs sndrs added 📶 Open Journalism run_chromatic Runs chromatic when label is applied labels Oct 5, 2023
@github-actions
Copy link

github-actions bot commented Oct 5, 2023 •
edited
Loading

Size Change: 0 B 🆕

Total Size: 0 B

compressed-size-action

@sndrs sndrs force-pushed the sndrs/prioritised-hydration branch 2 times, most recently from 3b99982 to b5965bc Compare October 5, 2023 15:04
mxdvl
mxdvl approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@mxdvl mxdvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Priority: CRITICAL

@sndrs sndrs force-pushed the sndrs/prioritised-hydration branch from b5965bc to 83bef58 Compare October 5, 2023 15:21
@mxdvl mxdvl merged commit 2bf0fe3 into oj/adaptive/prioritised-hydration Oct 5, 2023
@mxdvl mxdvl deleted the sndrs/prioritised-hydration branch October 5, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mxdvl mxdvl mxdvl approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
dotcom-rendering run_chromatic Runs chromatic when label is applied 📶 Open Journalism
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sndrs @mxdvl