Skip to content

Adaptive site: hydrate islands according to their priority #9021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 6, 2023
Merged

Adaptive site: hydrate islands according to their priority #9021

merged 5 commits into from
Oct 6, 2023

Conversation

sndrs
Copy link
Member

@sndrs sndrs commented Oct 4, 2023 •
edited
Loading

depends on #8970...

What does this change?

  • uses the scheduler to hydrate islands according to their priority prop

Why?

  • ensures higher priority island are hydrated before lower priority tasks are run

@sndrs sndrs force-pushed the oj/adaptive/island-priorities branch from d284108 to dadb0eb Compare October 4, 2023 13:34
@sndrs @mxdvl
Hydrate islands according to their priority
aa17e15 
Co-authored-by: Max Duval <max.duval@theguardian.com>
@sndrs sndrs force-pushed the oj/adaptive/prioritised-hydration branch from a01f881 to aa17e15 Compare October 4, 2023 13:36
@github-actions
Copy link

github-actions bot commented Oct 4, 2023 •
edited
Loading

Size Change: 0 B 🆕

Total Size: 0 B

compressed-size-action

mxdvl
mxdvl reviewed Oct 4, 2023
View reviewed changes
Copy link
Contributor

@mxdvl mxdvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean!

@sndrs sndrs mentioned this pull request Oct 4, 2023
Merged
@sndrs sndrs marked this pull request as ready for review October 4, 2023 14:39
@sndrs sndrs requested a review from a team as a code owner October 4, 2023 14:39
@mxdvl mxdvl added 📶 Open Journalism run_chromatic Runs chromatic when label is applied labels Oct 4, 2023
cemms1
cemms1 reviewed Oct 5, 2023
View reviewed changes
Base automatically changed from oj/adaptive/island-priorities to main October 5, 2023 13:41
@sndrs sndrs mentioned this pull request Oct 5, 2023
Merged
@sndrs
Do actually hydrate islands according to their priority... (#9035)
2bf0fe3 
* actually apply priority settings to islands!

* dont bind
@mxdvl mxdvl requested a review from cemms1 October 5, 2023 15:38
cemms1
cemms1 reviewed Oct 5, 2023
View reviewed changes
@sndrs @cemms1 @mxdvl
docs(getPriority): more explicit error message
f689b80 
Co-authored-by: Charlotte Emms <43961396+cemms1@users.noreply.github.com>
@mxdvl mxdvl force-pushed the oj/adaptive/prioritised-hydration branch from 7216921 to f689b80 Compare October 6, 2023 07:39
mxdvl
mxdvl reviewed Oct 6, 2023
View reviewed changes
Copy link
Contributor

@mxdvl mxdvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should keep the whenVisible and onInteraction callback signatures as they were?

@sndrs sndrs merged commit 18446c5 into main Oct 6, 2023
@sndrs sndrs deleted the oj/adaptive/prioritised-hydration branch October 6, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cemms1 cemms1 cemms1 approved these changes

+1 more reviewer

@mxdvl mxdvl mxdvl left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
dotcom-rendering run_chromatic Runs chromatic when label is applied 📶 Open Journalism
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sndrs @mxdvl @cemms1