kqueue: set O_CLOEXEC on close pipe fds #617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These file descriptors are being leaked to child processes because O_CLOEXEC isn't set.
arp242
added a commit
that referenced
this pull request
Apr 25, 2024
Seems to work now(?) This exception has been there for years, but now it consistently seems to fail both for me locally and in the CI (for example in #617). But on the main branch it worked just a few weeks ago(?) And while the CI could have been updated, my local environment hasn't: netbsd$ uname -a NetBSD 9.2 (GENERIC) #0: Wed May 12 13:15:55 UTC 2021 mkrepro@mkrepro.NetBSD.org:/usr/src/sys/arch/amd64/compile/GENERIC 🤷
Merged
arp242
added a commit
that referenced
this pull request
Apr 25, 2024
Seems to work now(?) This exception has been there for years, but now it consistently seems to fail both for me locally and in the CI (for example in #617). But on the main branch it worked just a few weeks ago(?) And while the CI could have been updated, my local environment hasn't: netbsd$ uname -a NetBSD 9.2 (GENERIC) #0: Wed May 12 13:15:55 UTC 2021 mkrepro@mkrepro.NetBSD.org:/usr/src/sys/arch/amd64/compile/GENERIC 🤷
|
Thanks. (CI failure is unrelated; fixed that in #618) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These file descriptors are being leaked to child processes because O_CLOEXEC isn't set.