fix(UX): Misc #334
Merged
fix(UX): Misc #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes zoom lag in new chrome browser. Apparenlty, combination of border-radius + box-shadow + css scale change is computationally very heavy for chrome browser (Although, it works well on Firefox and used to work in old chrome browser)
To avoid unnecesary updates while resetting block
- Since it sometimes used to trigger updateDropTarget after drop event which used leave isDragging: true. This prevented the editor resizer from appearing after the drop. - Also, refactored code a bit to avoid unnecessary DOM updates
So that on replacing image after drop, dimension of the image remains almost same
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #334 +/- ##
========================================
Coverage 41.61% 41.61%
========================================
Files 16 16
Lines 1139 1139
========================================
Hits 474 474
Misses 665 665 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🎉 This PR is included in version 1.16.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updating Chrome, canvas zoom suddenly started appearing choppy. This is a Chrome-specific issue since it worked fine in Firefox and used to work fine in the previous Chrome version. After some trial-n-error & investigation, I found that the combination of complex
box-shadow+border-radius+scalechange is computationally very heavy for Chrome renderer, so for now I chose to removeborder-radiusto fix the choppy zoom issue.Before:
(on chrome 134+)
Screen.Recording.2025-03-29.at.2.17.03.PM.mov
After:
Screen.Recording.2025-03-29.at.2.15.25.PM.mov
throttleforupdateDropTarget(it anyway is not making any network call or CPU heavy work and also there is a check to avoid unnecessary DOM updates) because it sometimes used to triggerupdateDropTargetafter drop event which used leave isDragging: true. This prevented the editor resizer from appearing after the drop.Before:
Screen.Recording.2025-03-29.at.2.43.50.PM.mov
After:
Screen.Recording.2025-03-29.at.2.44.38.PM.mov
Before:
Screen.Recording.2025-03-29.at.2.57.05.PM.mov
After:
Screen.Recording.2025-03-29.at.2.56.38.PM.mov
Other fixes:
falseornull. This issue got introduced after refactor(store): Split store into more logical and smaller stores #327