fix: Hide edit icon for Website Users #325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #325 +/- ##
========================================
Coverage 41.68% 41.68%
========================================
Files 16 16
Lines 1137 1137
========================================
Hits 474 474
Misses 663 663 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@Mergifyio backport master |
✅ Backports have been created
|
surajshetty3416
added a commit
that referenced
this pull request
Mar 28, 2025
fix: Hide edit icon for Website Users (backport #325)
|
🎉 This PR is included in version 1.16.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
surajshetty3416
added a commit
that referenced
this pull request
Jul 1, 2025
fix: Hide edit icon for Website Users
surajshetty3416
added a commit
to surajshetty3416/builder
that referenced
this pull request
Jul 30, 2025
fix: Hide edit icon for Website Users (backport frappe#325)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the Builder edit icon was visible to users who don't have sufficient permissions to edit pages, such as Website Users.
Changes
Why
Previously, the edit icon was being displayed for all logged-in users, including Website Users who don't have permission to use Builder. This was confusing as clicking the icon would lead them to an access denied page.
Testing