Skip to content

Fix compatibility with PHP 8.1 #1312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 31, 2022
Merged

Fix compatibility with PHP 8.1 #1312

merged 6 commits into from
Jan 31, 2022

Conversation

jtojnar
Copy link
Member

@jtojnar jtojnar commented Jan 23, 2022 •
edited
Loading

Fixes: #1294

@jtojnar jtojnar mentioned this pull request Jan 23, 2022
Closed
@jtojnar jtojnar marked this pull request as draft January 25, 2022 15:00
@jtojnar
tests: ignore deprecation triggered by Dice
ee3c9be 
error_reporting is insufficient with PHP 8.1.
@jtojnar
composer: Switch to phpunit-bridge
a30a68f 
The phpunit version that supports PHP 5.6 is not compatible with PHP 8.1
so we need to rely on this indirection for now.
@jtojnar
composer: Update fatfree to master
b6ebcc4 
To support PHP 8.1.
@jtojnar jtojnar changed the title Use our fork of fatfree Fix compatibility with PHP 8.1 Jan 30, 2022
@jtojnar jtojnar marked this pull request as ready for review January 30, 2022 18:00
@jtojnar jtojnar marked this pull request as draft January 30, 2022 18:16
@jtojnar jtojnar marked this pull request as ready for review January 30, 2022 20:03
@jtojnar
Copy link
Member Author

jtojnar commented Jan 30, 2022

Test complains

Deprecated: Return type of GuzzleHttp\Handler\MockHandler::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/runner/work/selfoss/selfoss/vendor/guzzlehttp/guzzle/src/Handler/MockHandler.php on line 173

but it does not seem to make it fail. Opened guzzle/guzzle#2983.

We should also wait for new version of fatfree to be released.

@jtojnar jtojnar added this to the 2.19 milestone Jan 30, 2022
@jtojnar jtojnar merged commit 727393e into master Jan 31, 2022
@jtojnar jtojnar deleted the php81 branch January 31, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.19
Development

Successfully merging this pull request may close these issues.

PHP 8.1 support
1 participant
@jtojnar