Add attribute to avoid deprection warnings on PHP 8.1 #2983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP 8.1 considers missing return typehints different from the interfaces.
|
The CI failures seem unrelated. I can try to fix them in a separate PR if you feel it is worth it. |
|
Guzzle 6 is both EOL and also not compatible with PHP 8. Please upgrade to Guzzle 7. |
|
Unfortunately, I also need to support PHP 5.6 (since that is what some LTS distros still have) so upgrading is not possible for me at the moment. But if Guzzle 6 is EOL, I guess I need to do it in a different way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.1 considers missing return typehints different from the interfaces.