Disallow unichar_t popup messages on GGadgetData initialisation; remove gg_utf8_popup flag #3914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctrlcctrlv
approved these changes
Aug 31, 2019
khaledhosny
reviewed
Sep 1, 2019
| g->popup_msg = (gd->flags&gg_utf8_popup) | ||
| ? utf82u_copy((char *) gd->popup_msg) | ||
| : u_copy(gd->popup_msg); | ||
| g->popup_msg = utf82u_copy(gd->popup_msg); |
There was a problem hiding this comment.
Isn’t popup_msg a char * now? So this should be copy()?
8 tasks
Omnikron13
pushed a commit
to Omnikron13/fontforge
that referenced
this pull request
May 31, 2022
Disallow unichar_t popup messages on GGadgetData initialisation; remove gg_utf8_popup flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the popup messages were really already gettext localised strings anyway. So this removes the possibility of mistakenly not specifying the
gg_utf8_popupflag (see #3877), and removes the need to cast to unichar_t on initialisationType of change