Splash screen title bar removal #3795
Conversation
|
(Obviously) this code looks fine too. |
Hoorah =) FontForge === ♥ |
fontforgeexe/startui.c
Outdated
| GDrawSetVisible(splashw,true); | ||
|
|
||
| GDrawSync(NULL); |
There was a problem hiding this comment.
Likewise, adding whitespace to unrelated areas of the code just makes git blame harder to read.
There was a problem hiding this comment.
Oh gosh thought I got them all, yep, will figure out mah editor =PP
fontforgeexe/startui.c
Outdated
| wattrs.cursor = ct_pointer; | ||
| wattrs.utf8_window_title = "FontForge"; | ||
| wattrs.border_width = 2; | ||
| //wattrs.utf8_window_title = "FontForge"; |
There was a problem hiding this comment.
This comment can be removed too.
Thank you for your contribution, by the way, we are always happy to have new contributors and hope for many more :-)
There was a problem hiding this comment.
Thanks!
Yep, looking to work on areas as I learn where and what they are
Cleaning Comments
| @@ -1248,12 +1248,12 @@ int fontforge_main( int argc, char **argv ) { | |||
| /* the window around, which I can determine if I have a positioned */ | |||
There was a problem hiding this comment.
This is kind of contradicting this comment now...
There was a problem hiding this comment.
1250: /* Actually I don't care any more */
That's George, lol. Maybe delete the whole comment block?
|
I actually prefer if we kept the title bar. Now I can't move the splash screen at all, and that's a problem because it's basically off the screen: |
|
I guess I didn't review this carefully enough. I think it's a reasonable stylistic choice to avoid putting the title bar on the splash screen, but the about window should have one. I thought the change was limited to the former, but (unless something strange is happening) @jtanx's picture shows the latter. Could we iterate on this change to split the cases, and if we did that would @jtanx be OK with the result? |
|
Ok, so the about dialog definitely should have a border, no questions about that. If you can find a way to not have decor on the splash but on the about dialog then that's ok with me. But I can already tell, you're going to run into problems, because those styles can only be specified on window creation and the splash window is overloaded, it's used for other tasks too apart from displaying the splash screen (e.g. autosaving and something about clipboard processing, not sure if that still works though.) |
This reverts commit 769445a.
|
Sorry, I also missed that bug, ugh. I've reverted this until it can be fixed…as @happyrobotstudio already deleted the branch most likely a new PR needs to be opened, I'm not sure that creating a new branch with the same name as a deleted branch works on Github. |
|
Hmmm, potentially I can do some toying around with screen co-ords and ensure a nice placement of the screen? I would really enjoy the splash without the title =PP |
|
I will work on trying to get a reasonably placed window, And also to not destroy the title bar for the about section Ok, thanks everyone for feedback, will post changes for review soon |
Apologies for that, just getting sorted out with my git ... Will keep branches open in future |
Indeed the about page should be as usual with a title bar, some further looking into the window creation to split out the cases may be needed I'll keep at it |
|
Ok, yes after carefully reading I see the difficulty, being that the splash window performs some other functions, and those may be affected by the window mask specified. Hmmz. From a user experience perspective, a solid loading screen makes me love a program =P I'll use this as my intro to X11 ... try and figure out something I have another PR regarding the Splash Screen Timeout, simply adding an integer for the desired seconds to timeout the splash screen .. that seems ok as a simple change =P I will cut my teeth with X11 on _NET_WM_WINDOW_TYPE_SPLASH etc etc and see what might work maybe sorta |
If it's anything x11 specific it won't be accepted. We're already moving away from that by going through gdk (and eventually gtk most likely) Maybe splitting out a new window just for the startup splash might work, but that's some effort I won't undertake myself. |
* Shorten splash timout to 3200ms, remove splash window titlebar (wam_nodecor) * Remove comment * Ensure a splash time of 7 seconds, yet make use of wam_nodecor to remove the title bar * Comment remove * Cleaning comments * Cleaning Comments
Ensuring the splash screen is displayed for 7 seconds, yet making use of wam_nodecor to take away the title bar for aesthetic pleasure (click on image will close also, title bar is reduntant functionally and visually for splash screen).