Add flags to Python font.transform() #4980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtanx
reviewed
Apr 24, 2022
fontforge/python.c
Outdated
| return( NULL ); | ||
| // Flip fvt_alllayers back | ||
| if ( flags&fvt_alllayers ) | ||
| flags |= fvt_alllayers; |
There was a problem hiding this comment.
Why is this needed? Isn't this a no-op?
There was a problem hiding this comment.
The intention was to have fvt_alllayers in the python flags be opposite to that in the flags passed down (as its supposed to be on by default). I'll take a look later.
There was a problem hiding this comment.
It's going to be Wed evening at the earliest before I could do something about this properly, but I believe the line should read flags &= ~fvt_alllayers; . I just goofed it, apparently. If that makes sense to you and you want to integrate early, go ahead.
There was a problem hiding this comment.
OK, had time to actually look at and revise this. I just had the two bit-flipping lines in the wrong positions.
jtanx
approved these changes
Apr 28, 2022
Omnikron13
pushed a commit
to Omnikron13/fontforge
that referenced
this pull request
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4976
This is specific enough that I don't think it needs automated tests. I did basic checks on each of the flags.