Fix normalisation of absolute paths #4963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skef
approved these changes
Mar 23, 2022
| strcat(buffer,"/"); | ||
| strcat(buffer,name); | ||
|
|
||
| buffer = smprintf("%s/%s", dirname_, name); |
There was a problem hiding this comment.
I'm assuming getcwd won't return a trailing slash, hence removing that check.
There was a problem hiding this comment.
More like the code below already deals with removing redundant slashes, so there's no point checking for it here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4956 depends on the path being normalised, but the fallback path for older glib versions doesn't do anything if the path is absolute. This changes it to always normalise paths. Also fixes potential buffer overflows on long path names.
Type of change