Fix name extraction for Type3 fonts from pdfs #4960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtanx
reviewed
Mar 21, 2022
jtanx
reviewed
Mar 22, 2022
Omnikron13
pushed a commit
to Omnikron13/fontforge
that referenced
this pull request
May 31, 2022
* Fix font name for type3 extraction from pdfs * free name on failure * simplify free
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug when extracting Type3 fonts from PDFs. In the existing code,
nameis pointed to the correct place in the font dictionary, butpdf_getcharprocsreads the Charprocs dictionary before the name is copied. This causes the later name copy step to read a random section of the CharProcs dict instead. This change copies the name out before loading CharProcs.Type of change
Bug fix