Skip to content

gfilechooser.c: fix behaviour when changing file type #4939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2022
Merged

gfilechooser.c: fix behaviour when changing file type #4939

merged 1 commit into from
Mar 9, 2022

Conversation

jtanx
Copy link
Contributor

@jtanx jtanx commented Mar 9, 2022

Fixes the first issue raised in #4937.

Regression from #4828 - restores this code:

fontforge/gdraw/gfilechooser.c

Lines 405 to 409 in 21ad4a1

if ( gfc->lastname!=NULL ) {
GGadgetSetTitle(&gfc->name->g,gfc->lastname);
free(gfc->lastname);
gfc->lastname=NULL;
}

Type of change

  • Bug fix

skef
skef approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@skef skef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jtanx jtanx merged commit 784cd0a into fontforge:master Mar 9, 2022
@jtanx jtanx deleted the df branch March 9, 2022 19:59
@ctrlcctrlv ctrlcctrlv mentioned this pull request Apr 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skef skef skef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtanx @skef