Remove remaining gio remnants #4828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e3f7fe4 to
132f0f7
Compare
Obsoleted since the removal of the FTP layer; all file system actions are synchronous so no need to interface through George's gio layer Mime implemenation was loosely based on https://github.com/fontforge/fontforge/blob/v20120731-b/gutils/giomime.c
frank-trampe
reviewed
Oct 5, 2021
| return ret; | ||
| } | ||
|
|
||
| enum fchooserret GFileChooserDefFilter(GGadget *g,const struct gdirentry *ent,const char *dir) { |
There was a problem hiding this comment.
What's the story behind un-Unicoding dir?
There was a problem hiding this comment.
No point making it unichar when everything converts back to the utf-8 form anyway
frank-trampe
reviewed
Oct 5, 2021
| char utf8_ent_name[PATH_MAX+1]; | ||
| strncpy(utf8_ent_name,u_to_c( ent->name ),PATH_MAX); | ||
| utf8_ent_name[PATH_MAX]=0; | ||
| mime = GIOGetMimeType(utf8_ent_name); |
There was a problem hiding this comment.
Where did this functionality go?
There was a problem hiding this comment.
Oh. Found it. (Search for GFileMimeType.)
frank-trampe
reviewed
Oct 5, 2021
| @@ -510,19 +459,6 @@ static void GFileChooserScanDir(GFileChooser *gfc,unichar_t *dir) { | |||
| GGadgetSetList(&gfc->directories->g,ti,false); | |||
| GGadgetSelectOneListItem(&gfc->directories->g,0); | |||
|
|
|||
| if ( gfc->outstanding!=NULL ) { | |||
There was a problem hiding this comment.
What practical purpose did the outstanding logic serve?
There was a problem hiding this comment.
It was to support the async nature of FTP, like you can't get a response back immediately to directory operations.
Since we removed it, there's no need for this any more.
|
Any other comments? Otherwise going to merge. |
|
Just that I'm sad to see old code go. |
jtanx
added a commit
to jtanx/fontforge
that referenced
this pull request
Mar 9, 2022
Fixes the first issue raised in fontforge#4937. Regression from fontforge#4828.
Omnikron13
pushed a commit
to Omnikron13/fontforge
that referenced
this pull request
May 31, 2022
Obsoleted since the removal of the FTP layer; all file system actions are synchronous so no need to interface through George's gio layer Mime implemenation was loosely based on https://github.com/fontforge/fontforge/blob/v20120731-b/gutils/giomime.c
Omnikron13
pushed a commit
to Omnikron13/fontforge
that referenced
this pull request
May 31, 2022
Fixes the first issue raised in fontforge#4937. Regression from fontforge#4828.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Obsoleted since the removal of the FTP layer; all file system actions
are synchronous so no need to interface through George's gio layer
Mime implemenation was loosely based on
https://github.com/fontforge/fontforge/blob/v20120731-b/gutils/giomime.c
Type of change