Skip to content

Drop Python3.7, require 3.8+ and run tests on 3.11 too #2879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Nov 4, 2022
Merged

Drop Python3.7, require 3.8+ and run tests on 3.11 too #2879

merged 11 commits into from
Nov 4, 2022

Conversation

anthrotype
Copy link
Member

Fixes #2878 and #2163

@anthrotype
setup.py: drop soon EOL python 3.7, require 3.8+
496da99 
Fixes #2878 and #2163
@anthrotype
CI: test on 3.8 and 3.11, no longer 3.7
81efdb8
@anthrotype
tox.ini: bump lxml version so we get precompiled wheels for python3.11
cd6bc3b
@anthrotype
use lxml==4.9.0; 4.9.1 wheel can't be installed on M1 macs
b36247d 
#2676

I hope they fix that in the next release...
@anthrotype
test on 3.10 until lxml provides wheels for windows 3.11
99dabea 
looks like neither lxml 4.9.0 nor 4.9.1 provide precompiled wheels for Windows CPython 3.11 so for now continue to run tests on 3.10 until that's the case
@anthrotype
tox.ini: update envlist to drop 7 and add 11
7834cf3
@anthrotype
setup.py: update PyPI Trove Classifiers to mention the array of suppo…
8346308 
…rted pythons
@anthrotype
tox.ini: force pip to install --only-binary=lxml
4baa08c
@anthrotype
CI: run tox in verbose mode to debug package installation
34dad6d
@anthrotype
bump skia-pathops==0.7.3 so we install 3.11 wheels
f15efa0
@anthrotype
Copy link
Member Author

We currently test the minimum and maximum required pythons, previously it was 3.7 (on linux only) and 3.10 (on all of linux, mac and windows).
Initially, in this PR, I tried to bump those to 3.8 (linux) and 3.11 (linux, mac, win), but encountered issues because lxml (again!) doesn't provide wheels for 3.11 for all three. So I reverted to testing 3.10 on linux, mac and windows for the main test suite.
I still left one CI build that's using Python 3.11, that's the one that tests building the cython modules, and only runs on linux and runs test that don't require lxml so it worked in that case.

So this is ready to be merged, provided everyone is happy about dropping support for Python 3.7.
I will interpret silence as consent if nobody raises concerns within a couple days time.

@anthrotype anthrotype merged commit 66a3ec9 into main Nov 4, 2022
@anthrotype anthrotype deleted the drop-py37 branch November 4, 2022 18:43
anthrotype added a commit to fonttools/ufoLib2 that referenced this pull request Nov 6, 2022
@anthrotype
Drop support Python 3.7, run tests on Python 3.11
b21b181 
FontTools has dropped support for 3.7, thus we follow suit

fonttools/fonttools#2879
fonttools/fonttools#2878
@anthrotype anthrotype mentioned this pull request Nov 6, 2022
Merged
anthrotype added a commit to fonttools/ufoLib2 that referenced this pull request Nov 6, 2022
@anthrotype
Drop support Python 3.7, run tests on Python 3.11
0081fb6 
FontTools has dropped support for 3.7, thus we follow suit

fonttools/fonttools#2879
fonttools/fonttools#2878
@madig
Copy link
Collaborator

madig commented Nov 7, 2022

I'm wondering if we want to start using pip-tools for requirements management? The text files seem handwritten to me currently, and some deps are pinned in tox instead. We could instead pip-compile several requirements files ready to be used as is in testing? Then there's one way to do dep testing.

@anthrotype
Copy link
Member Author

sounds good, wanna send a PR?

@anthrotype anthrotype mentioned this pull request Nov 11, 2022
Closed
anthrotype added a commit that referenced this pull request Nov 14, 2022
@anthrotype
Revert "Merge pull request #2879 from fonttools/drop-py37"
f21e676 
This reverts commit 66a3ec9, reversing
changes made to 82b9023.

A major user of fontTools, RoboFont, will need a bit more time to wean itself from Python 3.7.
We can delay this change by a few more months to give them time to upgrade.
anthrotype added a commit that referenced this pull request Nov 14, 2022
@anthrotype
cerry-pick packaging & ci changes from reverted PR #2879
cf28372
@anthrotype
Copy link
Member Author

I just reverted this PR with f21e676. We shall re-revert once a new RoboFont is released, which I hear will use (at least) Python 3.9. I can't speak of Robofont schedule, but I would like to be able to drop Python 3.7 support by the end of this year.

anthrotype added a commit that referenced this pull request Feb 2, 2023
@anthrotype
Drop Python3.7, require 3.8+
7f4fe17 
Revert "Revert "Merge pull request #2879 from fonttools/drop-py37""

This reverts commit f21e676.

Which in turn, reverted #2879
@anthrotype anthrotype mentioned this pull request Feb 2, 2023
Merged
khaledhosny pushed a commit to fonttools/ufoLib2 that referenced this pull request Dec 2, 2023
@anthrotype @khaledhosny
Drop support Python 3.7, run tests on Python 3.11
420444a 
FontTools has dropped support for 3.7, thus we follow suit

fonttools/fonttools#2879
fonttools/fonttools#2878
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

drop support for 3.7?
2 participants
@anthrotype @madig