Skip to content

Remove workaround (#1381) #1788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 3, 2025
Merged

Remove workaround (#1381) #1788

merged 2 commits into from
Feb 3, 2025

Conversation

jenskutilek
Copy link
Collaborator

Apparently the macOS bug has been fixed. I'm not sure when, but in 10.14.6 the workaround introduced in #1381 is not needed anymore. Can anybody confirm?

@jenskutilek
Copy link
Collaborator Author

Anecdotally, removing the workaround saves me 11kB (61kB to 50kB) on one of the TTFs from https://github.com/jenskutilek/homecomputer-fonts.

@anthrotype
Copy link
Member

in 10.14.6 the workaround introduced in #1381 is not needed anymore

That's great to hear.

removing the workaround saves me 11kB (61kB to 50kB)

Hm that's a lot, but I am inclined to keep this in by default, given that 10.14 is relatively recent.
Maybe we could add a command-line option to fonttools varLib to disable this.

Base automatically changed from master to main February 17, 2021 11:55
@behdad
Copy link
Member

behdad commented Aug 16, 2022

2.5 years later. Let's decide when is a good time to remove the workaround.

@justvanrossum
Copy link
Collaborator

Since it was a problem introduced with macOS 10.14, and was apparently fixed latest in 10.14.6, the time to remove the workaround should be now...

@Lorp
Copy link

Lorp commented Aug 16, 2022

See #1381 (comment) about a current macOS bug that appears to hit glyphs containing components with zero deltas.

@jenskutilek jenskutilek mentioned this pull request Sep 22, 2022
Closed
@rsheeter rsheeter mentioned this pull request May 17, 2023
Closed
@anthrotype
Copy link
Member

anthrotype commented Aug 15, 2023 •
edited
Loading

one year later, what shall we do here?

a current macOS bug that appears to hit glyphs containing components with zero deltas.

@Lorp what happened to that ever since?

@anthrotype anthrotype force-pushed the remove-gvar-zero-workaround branch from 648dc2a to 2e13c73 Compare February 3, 2025 12:25
@anthrotype
Copy link
Member

5 years later, now really is time to remove the workaround

@anthrotype anthrotype merged commit 696719b into main Feb 3, 2025
12 checks passed
@anthrotype anthrotype deleted the remove-gvar-zero-workaround branch February 3, 2025 12:44
anthrotype added a commit to googlefonts/fontc that referenced this pull request Feb 3, 2025
@anthrotype
[fontbe] remove workaround for old macOS bug with composites with all…
d711677 
…-zero deltas

Now that fonttools has also removed this old workaround, we shall remove it as well in fontc.

See fonttools/fonttools#1788

Fixes #283
@anthrotype anthrotype mentioned this pull request Feb 3, 2025
Merged
anthrotype added a commit to googlefonts/fontc that referenced this pull request Feb 7, 2025
@anthrotype
[fontbe] remove workaround for old macOS bug with composites with all…
cd51b7a 
…-zero deltas

Now that fonttools has also removed this old workaround, we shall remove it as well in fontc.

See fonttools/fonttools#1788

Fixes #283
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthrotype anthrotype Awaiting requested review from anthrotype

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jenskutilek @anthrotype @behdad @justvanrossum @Lorp