[google_sign_in] Use an activity for credential requests #9497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`getCredentialManager` is documented to require an activity context, not an application context; this fixes it to use the activity context since in some configurations using the application context will throw an error. Fixes flutter/flutter#171122
reidbaker
approved these changes
Jun 26, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 27, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 27, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 27, 2025
flutter/packages@2c8d2bc...4841ada 2025-06-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ci] Check macOS 15 for Xcode analyzer warnings (#9427)" (flutter/packages#9509) 2025-06-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ci] Remove in_app_purchase_storekit from Xcode analyzer exclusion list (#9429)" (flutter/packages#9507) 2025-06-26 magder@google.com [ci] Check macOS 15 for Xcode analyzer warnings (flutter/packages#9427) 2025-06-26 magder@google.com [ci] Remove in_app_purchase_storekit from Xcode analyzer exclusion list (flutter/packages#9429) 2025-06-26 stuartmorgan@google.com [google_sign_in] Add contributor setup instructions (flutter/packages#9489) 2025-06-26 stuartmorgan@google.com [google_sign_in] Use an activity for credential requests (flutter/packages#9497) 2025-06-26 engine-flutter-autoroll@skia.org Roll Flutter from d733bea to 2773c0c (42 revisions) (flutter/packages#9495) 2025-06-26 stuartmorgan@google.com [extension_google_sign_in_as_googleapis_auth] Update to google_sign_in 7 (flutter/packages#9484) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Jul 21, 2025
…r#171292) flutter/packages@2c8d2bc...4841ada 2025-06-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ci] Check macOS 15 for Xcode analyzer warnings (flutter#9427)" (flutter/packages#9509) 2025-06-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ci] Remove in_app_purchase_storekit from Xcode analyzer exclusion list (flutter#9429)" (flutter/packages#9507) 2025-06-26 magder@google.com [ci] Check macOS 15 for Xcode analyzer warnings (flutter/packages#9427) 2025-06-26 magder@google.com [ci] Remove in_app_purchase_storekit from Xcode analyzer exclusion list (flutter/packages#9429) 2025-06-26 stuartmorgan@google.com [google_sign_in] Add contributor setup instructions (flutter/packages#9489) 2025-06-26 stuartmorgan@google.com [google_sign_in] Use an activity for credential requests (flutter/packages#9497) 2025-06-26 engine-flutter-autoroll@skia.org Roll Flutter from d733bea to 2773c0c (42 revisions) (flutter/packages#9495) 2025-06-26 stuartmorgan@google.com [extension_google_sign_in_as_googleapis_auth] Update to google_sign_in 7 (flutter/packages#9484) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth
pushed a commit
to vashworth/packages
that referenced
this pull request
Jul 30, 2025
`getCredentialManager` is documented to require an activity context, not an application context; this fixes it to use the activity context since in some configurations using the application context will throw an error. Fixes flutter/flutter#171122 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getCredentialManageris documented to require an activity context, not an application context; this fixes it to use the activity context since in some configurations using the application context will throw an error.Fixes flutter/flutter#171122
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3