Skip to content

[go_router_builder] Update case sensitive test to go_router 16.0.0 #9482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 10, 2025
Merged

[go_router_builder] Update case sensitive test to go_router 16.0.0 #9482

merged 2 commits into from
Jul 10, 2025

Conversation

ValentinVignal
Copy link
Contributor

Part of

Follow-up of

Unskips and migrates the test about case sensitivity to the new version of go_router 15.2.4.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3

@ValentinVignal ValentinVignal requested a review from chunhtai as a code owner June 24, 2025 05:48
This was referenced Jun 24, 2025
Merged
Merged
@ValentinVignal ValentinVignal force-pushed the go-router-builder/update-tests-to-go-router-15.2.4 branch 3 times, most recently from c0d2b46 to 6920326 Compare July 1, 2025 01:57
chunhtai
chunhtai approved these changes Jul 2, 2025
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the version is updated

packages/go_router_builder/example/pubspec.yaml Outdated
@@ -9,7 +9,7 @@ dependencies:
collection: ^1.15.0
flutter:
sdk: flutter
go_router: ^15.1.1
go_router: ^15.2.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be 16.0.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chunhtai I updated it in Update version number

@ValentinVignal ValentinVignal force-pushed the go-router-builder/update-tests-to-go-router-15.2.4 branch from 6920326 to 770d64e Compare July 3, 2025 03:19
@ValentinVignal ValentinVignal changed the title [go_router_builder] Update case sensitive test to go_router 15.2.4 [go_router_builder] Update case sensitive test to go_router 16.0.0 Jul 3, 2025
@ValentinVignal ValentinVignal added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 10, 2025
@auto-submit auto-submit bot merged commit e45672a into flutter:main Jul 10, 2025
78 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 17, 2025
@engine-flutter-autoroll
e45672a34 [go_router_builder] Update case sensitive test to `go_route…
f134c7e 
…r` 16.0.0 (flutter/packages#9482)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 17, 2025
@engine-flutter-autoroll
e45672a34 [go_router_builder] Update case sensitive test to `go_route…
c2dd4a4 
…r` 16.0.0 (flutter/packages#9482)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 17, 2025
@engine-flutter-autoroll
e45672a34 [go_router_builder] Update case sensitive test to `go_route…
af487dc 
…r` 16.0.0 (flutter/packages#9482)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 17, 2025
@engine-flutter-autoroll
e45672a34 [go_router_builder] Update case sensitive test to `go_route…
1bb816d 
…r` 16.0.0 (flutter/packages#9482)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 17, 2025
@engine-flutter-autoroll
e45672a34 [go_router_builder] Update case sensitive test to `go_route…
5c012a7 
…r` 16.0.0 (flutter/packages#9482)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2025
Merged
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Jul 17, 2025
@engine-flutter-autoroll
Roll Packages from 4a231ae8546d to cb8fef62993f (31 revisions) (#172303)
ae0700d 
flutter/packages@4a231ae...cb8fef6

2025-07-17 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump androidx.activity:activity from 1.9.3 to 1.10.1 in
/packages/image_picker/image_picker_android/android
(flutter/packages#8725)
2025-07-17 stuartmorgan@google.com [webview_flutter] Update
androidx.webkit to 1.14.0 (flutter/packages#9638)
2025-07-17 engine-flutter-autoroll@skia.org Roll Flutter from
c2739f0 to 9c626d9 (18 revisions) (flutter/packages#9641)
2025-07-17 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
077b4a4 to d7b523b (3 revisions) (flutter/packages#9640)
2025-07-17 stuartmorgan@google.com Fix Gemini note wrapping
(flutter/packages#9639)
2025-07-17 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.google.android.gms:play-services-maps from 18.2.0
to 19.2.0 in
/packages/google_maps_flutter/google_maps_flutter_android/android
(flutter/packages#9120)
2025-07-17 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump androidx.fragment:fragment from 1.6.2 to 1.8.8 in
/packages/local_auth/local_auth_android/android (flutter/packages#9406)
2025-07-16 stuartmorgan@google.com [ci] Add Gemini Code Assist review
config (flutter/packages#9632)
2025-07-16 engine-flutter-autoroll@skia.org Roll Flutter from
cc3110c to c2739f0 (15 revisions) (flutter/packages#9633)
2025-07-16 105786499+syedaniq@users.noreply.github.com [image_picker]
redesign example app (flutter/packages#9625)
2025-07-16 robert.odrowaz@leancode.pl [camera_avfoundation]
Implementation swift migration - part 7 (flutter/packages#9595)
2025-07-15 10687576+bparrishMines@users.noreply.github.com
[webview_flutter_wkwebview] Replace Flutter method failure assertion
with nslog (flutter/packages#9587)
2025-07-15 engine-flutter-autoroll@skia.org Roll Flutter from
a930ec1 to cc3110c (24 revisions) (flutter/packages#9631)
2025-07-15 stuartmorgan@google.com [webview_flutter] Add
setMixedContentMode for Android (flutter/packages#9586)
2025-07-15 stuartmorgan@google.com [google_sign_in] Add exception info
to migration guide (flutter/packages#9574)
2025-07-14 392199+kwikwag@users.noreply.github.com [camera_android] Use
WeakReference to prevent startImageStream OOM error when main thread
hangs (#166533) (flutter/packages#9571)
2025-07-14 jason-simmons@users.noreply.github.com [quick_actions]
Restore the appShortcutLaunchActivityAfterStarting test in
quick_actions_android (flutter/packages#9508)
2025-07-14 engine-flutter-autoroll@skia.org Roll Flutter from
35f197f to a930ec1 (3 revisions) (flutter/packages#9624)
2025-07-14 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.android.tools.build:gradle from 8.9.1 to 8.11.1
in /packages/pigeon/platform_tests/test_plugin/android
(flutter/packages#9618)
2025-07-12 engine-flutter-autoroll@skia.org Roll Flutter from
43657f3 to 35f197f (39 revisions) (flutter/packages#9602)
2025-07-11 stuartmorgan@google.com Replace popularity badges
(flutter/packages#9594)
2025-07-11 1961493+harryterkelsen@users.noreply.github.com [rfw] Update
test to not depend on toString() (flutter/packages#9590)
2025-07-11 robert.odrowaz@leancode.pl [camera_avfoundation]
Implementation swift migration - part 6 (flutter/packages#9588)
2025-07-10 52160996+FMorschel@users.noreply.github.com [url_launcher]
Fixes new unnecessary boolean operations warnings
(flutter/packages#9409)
2025-07-10 stuartmorgan@google.com [google_sign_in] Add troubleshooting
to Android README (flutter/packages#9581)
2025-07-10 engine-flutter-autoroll@skia.org Roll Flutter from
ac12f66 to 43657f3 (25 revisions) (flutter/packages#9589)
2025-07-10 32538273+ValentinVignal@users.noreply.github.com
[go_router_builder] Update case sensitive test to `go_router` 16.0.0
(flutter/packages#9482)
2025-07-09 737941+loic-sharma@users.noreply.github.com [rfw] Remove the
RFW WASM example (flutter/packages#9551)
2025-07-09 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
fcf2c11 to 077b4a4 (5 revisions) (flutter/packages#9585)
2025-07-09 engine-flutter-autoroll@skia.org Roll Flutter from
adffe24 to ac12f66 (28 revisions) (flutter/packages#9584)
2025-07-09 malo.allee@gmail.com [video_player] Add html 5 video poster
support (thumbnail) as a VideoPlayerWebOptions (flutter/packages#8940)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
azatech pushed a commit to azatech/flutter that referenced this pull request Jul 28, 2025
@engine-flutter-autoroll @azatech
Roll Packages from 4a231ae8546d to cb8fef62993f (31 revisions) (flutt…
92ffbab 
…er#172303)

flutter/packages@4a231ae...cb8fef6

2025-07-17 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump androidx.activity:activity from 1.9.3 to 1.10.1 in
/packages/image_picker/image_picker_android/android
(flutter/packages#8725)
2025-07-17 stuartmorgan@google.com [webview_flutter] Update
androidx.webkit to 1.14.0 (flutter/packages#9638)
2025-07-17 engine-flutter-autoroll@skia.org Roll Flutter from
c2739f0 to 9c626d9 (18 revisions) (flutter/packages#9641)
2025-07-17 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
077b4a4 to d7b523b (3 revisions) (flutter/packages#9640)
2025-07-17 stuartmorgan@google.com Fix Gemini note wrapping
(flutter/packages#9639)
2025-07-17 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.google.android.gms:play-services-maps from 18.2.0
to 19.2.0 in
/packages/google_maps_flutter/google_maps_flutter_android/android
(flutter/packages#9120)
2025-07-17 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump androidx.fragment:fragment from 1.6.2 to 1.8.8 in
/packages/local_auth/local_auth_android/android (flutter/packages#9406)
2025-07-16 stuartmorgan@google.com [ci] Add Gemini Code Assist review
config (flutter/packages#9632)
2025-07-16 engine-flutter-autoroll@skia.org Roll Flutter from
cc3110c to c2739f0 (15 revisions) (flutter/packages#9633)
2025-07-16 105786499+syedaniq@users.noreply.github.com [image_picker]
redesign example app (flutter/packages#9625)
2025-07-16 robert.odrowaz@leancode.pl [camera_avfoundation]
Implementation swift migration - part 7 (flutter/packages#9595)
2025-07-15 10687576+bparrishMines@users.noreply.github.com
[webview_flutter_wkwebview] Replace Flutter method failure assertion
with nslog (flutter/packages#9587)
2025-07-15 engine-flutter-autoroll@skia.org Roll Flutter from
a930ec1 to cc3110c (24 revisions) (flutter/packages#9631)
2025-07-15 stuartmorgan@google.com [webview_flutter] Add
setMixedContentMode for Android (flutter/packages#9586)
2025-07-15 stuartmorgan@google.com [google_sign_in] Add exception info
to migration guide (flutter/packages#9574)
2025-07-14 392199+kwikwag@users.noreply.github.com [camera_android] Use
WeakReference to prevent startImageStream OOM error when main thread
hangs (flutter#166533) (flutter/packages#9571)
2025-07-14 jason-simmons@users.noreply.github.com [quick_actions]
Restore the appShortcutLaunchActivityAfterStarting test in
quick_actions_android (flutter/packages#9508)
2025-07-14 engine-flutter-autoroll@skia.org Roll Flutter from
35f197f to a930ec1 (3 revisions) (flutter/packages#9624)
2025-07-14 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.android.tools.build:gradle from 8.9.1 to 8.11.1
in /packages/pigeon/platform_tests/test_plugin/android
(flutter/packages#9618)
2025-07-12 engine-flutter-autoroll@skia.org Roll Flutter from
43657f3 to 35f197f (39 revisions) (flutter/packages#9602)
2025-07-11 stuartmorgan@google.com Replace popularity badges
(flutter/packages#9594)
2025-07-11 1961493+harryterkelsen@users.noreply.github.com [rfw] Update
test to not depend on toString() (flutter/packages#9590)
2025-07-11 robert.odrowaz@leancode.pl [camera_avfoundation]
Implementation swift migration - part 6 (flutter/packages#9588)
2025-07-10 52160996+FMorschel@users.noreply.github.com [url_launcher]
Fixes new unnecessary boolean operations warnings
(flutter/packages#9409)
2025-07-10 stuartmorgan@google.com [google_sign_in] Add troubleshooting
to Android README (flutter/packages#9581)
2025-07-10 engine-flutter-autoroll@skia.org Roll Flutter from
ac12f66 to 43657f3 (25 revisions) (flutter/packages#9589)
2025-07-10 32538273+ValentinVignal@users.noreply.github.com
[go_router_builder] Update case sensitive test to `go_router` 16.0.0
(flutter/packages#9482)
2025-07-09 737941+loic-sharma@users.noreply.github.com [rfw] Remove the
RFW WASM example (flutter/packages#9551)
2025-07-09 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
fcf2c11 to 077b4a4 (5 revisions) (flutter/packages#9585)
2025-07-09 engine-flutter-autoroll@skia.org Roll Flutter from
adffe24 to ac12f66 (28 revisions) (flutter/packages#9584)
2025-07-09 malo.allee@gmail.com [video_player] Add html 5 video poster
support (thumbnail) as a VideoPlayerWebOptions (flutter/packages#8940)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth pushed a commit to vashworth/packages that referenced this pull request Jul 30, 2025
@ValentinVignal @vashworth
[go_router_builder] Update case sensitive test to go_router 16.0.0 (f…
41b50d8 
…lutter#9482)

Part of
- flutter/flutter#169809

Follow-up of 
- flutter#9426
- flutter#9444

Unskips and migrates the test about case sensitivity to the new version of `go_router` 15.2.4.

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
ksokolovskyi pushed a commit to ksokolovskyi/flutter that referenced this pull request Aug 19, 2025
@engine-flutter-autoroll @ksokolovskyi
Roll Packages from 4a231ae8546d to cb8fef62993f (31 revisions) (flutt…
c557c88 
…er#172303)

flutter/packages@4a231ae...cb8fef6

2025-07-17 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump androidx.activity:activity from 1.9.3 to 1.10.1 in
/packages/image_picker/image_picker_android/android
(flutter/packages#8725)
2025-07-17 stuartmorgan@google.com [webview_flutter] Update
androidx.webkit to 1.14.0 (flutter/packages#9638)
2025-07-17 engine-flutter-autoroll@skia.org Roll Flutter from
c2739f0 to 9c626d9 (18 revisions) (flutter/packages#9641)
2025-07-17 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
077b4a4 to d7b523b (3 revisions) (flutter/packages#9640)
2025-07-17 stuartmorgan@google.com Fix Gemini note wrapping
(flutter/packages#9639)
2025-07-17 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.google.android.gms:play-services-maps from 18.2.0
to 19.2.0 in
/packages/google_maps_flutter/google_maps_flutter_android/android
(flutter/packages#9120)
2025-07-17 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump androidx.fragment:fragment from 1.6.2 to 1.8.8 in
/packages/local_auth/local_auth_android/android (flutter/packages#9406)
2025-07-16 stuartmorgan@google.com [ci] Add Gemini Code Assist review
config (flutter/packages#9632)
2025-07-16 engine-flutter-autoroll@skia.org Roll Flutter from
cc3110c to c2739f0 (15 revisions) (flutter/packages#9633)
2025-07-16 105786499+syedaniq@users.noreply.github.com [image_picker]
redesign example app (flutter/packages#9625)
2025-07-16 robert.odrowaz@leancode.pl [camera_avfoundation]
Implementation swift migration - part 7 (flutter/packages#9595)
2025-07-15 10687576+bparrishMines@users.noreply.github.com
[webview_flutter_wkwebview] Replace Flutter method failure assertion
with nslog (flutter/packages#9587)
2025-07-15 engine-flutter-autoroll@skia.org Roll Flutter from
a930ec1 to cc3110c (24 revisions) (flutter/packages#9631)
2025-07-15 stuartmorgan@google.com [webview_flutter] Add
setMixedContentMode for Android (flutter/packages#9586)
2025-07-15 stuartmorgan@google.com [google_sign_in] Add exception info
to migration guide (flutter/packages#9574)
2025-07-14 392199+kwikwag@users.noreply.github.com [camera_android] Use
WeakReference to prevent startImageStream OOM error when main thread
hangs (flutter#166533) (flutter/packages#9571)
2025-07-14 jason-simmons@users.noreply.github.com [quick_actions]
Restore the appShortcutLaunchActivityAfterStarting test in
quick_actions_android (flutter/packages#9508)
2025-07-14 engine-flutter-autoroll@skia.org Roll Flutter from
35f197f to a930ec1 (3 revisions) (flutter/packages#9624)
2025-07-14 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.android.tools.build:gradle from 8.9.1 to 8.11.1
in /packages/pigeon/platform_tests/test_plugin/android
(flutter/packages#9618)
2025-07-12 engine-flutter-autoroll@skia.org Roll Flutter from
43657f3 to 35f197f (39 revisions) (flutter/packages#9602)
2025-07-11 stuartmorgan@google.com Replace popularity badges
(flutter/packages#9594)
2025-07-11 1961493+harryterkelsen@users.noreply.github.com [rfw] Update
test to not depend on toString() (flutter/packages#9590)
2025-07-11 robert.odrowaz@leancode.pl [camera_avfoundation]
Implementation swift migration - part 6 (flutter/packages#9588)
2025-07-10 52160996+FMorschel@users.noreply.github.com [url_launcher]
Fixes new unnecessary boolean operations warnings
(flutter/packages#9409)
2025-07-10 stuartmorgan@google.com [google_sign_in] Add troubleshooting
to Android README (flutter/packages#9581)
2025-07-10 engine-flutter-autoroll@skia.org Roll Flutter from
ac12f66 to 43657f3 (25 revisions) (flutter/packages#9589)
2025-07-10 32538273+ValentinVignal@users.noreply.github.com
[go_router_builder] Update case sensitive test to `go_router` 16.0.0
(flutter/packages#9482)
2025-07-09 737941+loic-sharma@users.noreply.github.com [rfw] Remove the
RFW WASM example (flutter/packages#9551)
2025-07-09 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
fcf2c11 to 077b4a4 (5 revisions) (flutter/packages#9585)
2025-07-09 engine-flutter-autoroll@skia.org Roll Flutter from
adffe24 to ac12f66 (28 revisions) (flutter/packages#9584)
2025-07-09 malo.allee@gmail.com [video_player] Add html 5 video poster
support (thumbnail) as a VideoPlayerWebOptions (flutter/packages#8940)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunhtai chunhtai chunhtai approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: go_router_builder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ValentinVignal @chunhtai