[google_maps_flutter] Annotate zIndex usage
#9462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marks intentional usage of the deprecated `zIndex`, per https://github.com/flutter/flutter/blob/main/docs/infra/Packages-Gardener-Rotation.md#deprecations On iOS, switches from `zIndex` to `zIndexInt` since it's converted to an int later anyway. Also switches the Android example app, since clients should be using the int version (and the example only uses integer values anyway).
reidbaker
approved these changes
Jun 20, 2025
tarrinneal
approved these changes
Jun 20, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 23, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 23, 2025
flutter/packages@7f41e75...02770da 2025-06-23 engine-flutter-autoroll@skia.org Roll Flutter from c7362b4 to 0ab008a (18 revisions) (flutter/packages#9472) 2025-06-20 stuartmorgan@google.com [video_player] Update tests for deprecatitons (flutter/packages#9463) 2025-06-20 stuartmorgan@google.com [google_maps_flutter] Annotate `zIndex` usage (flutter/packages#9462) 2025-06-20 engine-flutter-autoroll@skia.org Roll Flutter (stable) from b25305a to 6fba244 (11 revisions) (flutter/packages#9435) 2025-06-20 engine-flutter-autoroll@skia.org Roll Flutter from 85a9b4f to c7362b4 (14 revisions) (flutter/packages#9466) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Ortes
pushed a commit
to Ortes/packages
that referenced
this pull request
Jun 25, 2025
Marks intentional usage of the deprecated `zIndex`, per https://github.com/flutter/flutter/blob/main/docs/infra/Packages-Gardener-Rotation.md#deprecations On iOS, switches from `zIndex` to `zIndexInt` since it's converted to an int later anyway. Also switches the Android example app, since clients should be using the int version (and the example only uses integer values anyway). ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Jul 21, 2025
…r#171006) flutter/packages@7f41e75...02770da 2025-06-23 engine-flutter-autoroll@skia.org Roll Flutter from c7362b4 to 0ab008a (18 revisions) (flutter/packages#9472) 2025-06-20 stuartmorgan@google.com [video_player] Update tests for deprecatitons (flutter/packages#9463) 2025-06-20 stuartmorgan@google.com [google_maps_flutter] Annotate `zIndex` usage (flutter/packages#9462) 2025-06-20 engine-flutter-autoroll@skia.org Roll Flutter (stable) from b25305a to 6fba244 (11 revisions) (flutter/packages#9435) 2025-06-20 engine-flutter-autoroll@skia.org Roll Flutter from 85a9b4f to c7362b4 (14 revisions) (flutter/packages#9466) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth
pushed a commit
to vashworth/packages
that referenced
this pull request
Jul 30, 2025
Marks intentional usage of the deprecated `zIndex`, per https://github.com/flutter/flutter/blob/main/docs/infra/Packages-Gardener-Rotation.md#deprecations On iOS, switches from `zIndex` to `zIndexInt` since it's converted to an int later anyway. Also switches the Android example app, since clients should be using the int version (and the example only uses integer values anyway). ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marks intentional usage of the deprecated
zIndex, per https://github.com/flutter/flutter/blob/main/docs/infra/Packages-Gardener-Rotation.md#deprecationsOn iOS, switches from
zIndextozIndexIntsince it's converted to an int later anyway. Also switches the Android example app, since clients should be using the int version (and the example only uses integer values anyway).Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3