[webview_flutter_wkwebview] Fix testNilRequest test for macOS 15.5
#9330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 29, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 29, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 29, 2025
flutter/packages@5743798...4463066 2025-05-29 15619084+vashworth@users.noreply.github.com Allow tests to use macOS 14 or 15.5 (flutter/packages#9328) 2025-05-29 sokolovskyi.konstantin@gmail.com [camera_web] Remove mocktail dependency. (flutter/packages#9195) 2025-05-28 engine-flutter-autoroll@skia.org Roll Flutter from 4372bfb to 0e536eb (27 revisions) (flutter/packages#9334) 2025-05-28 robert.odrowaz@leancode.pl [camera_avfoundation] Implementation swift migration - part 3.5 (flutter/packages#9254) 2025-05-28 15619084+vashworth@users.noreply.github.com [webview_flutter_wkwebview] Fix `testNilRequest` test for macOS 15.5 (flutter/packages#9330) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
…lutter#9330) This test was introduced in flutter#8766 to fix a crash when `WKFrameInfo.request` returned nil. It appears that macOS 15.5 fixed `WKFrameInfo.request` so it no longer returns nil and instead returns an empty `URLRequest`. This updates the test to accept either `nil` or an empty `URLRequest`. Fixes flutter/flutter#169511. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Ortes
pushed a commit
to Ortes/packages
that referenced
this pull request
Jun 25, 2025
…lutter#9330) This test was introduced in flutter#8766 to fix a crash when `WKFrameInfo.request` returned nil. It appears that macOS 15.5 fixed `WKFrameInfo.request` so it no longer returns nil and instead returns an empty `URLRequest`. This updates the test to accept either `nil` or an empty `URLRequest`. Fixes flutter/flutter#169511. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was introduced in #8766 to fix a crash when
WKFrameInfo.requestreturned nil. It appears that macOS 15.5 fixedWKFrameInfo.requestso it no longer returns nil and instead returns an emptyURLRequest. This updates the test to accept eithernilor an emptyURLRequest.Fixes flutter/flutter#169511.
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3