Skip to content

[in_app_purchase_storekit] Make Storekit 2 the default #9178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
May 12, 2025
Merged

[in_app_purchase_storekit] Make Storekit 2 the default #9178

merged 25 commits into from
May 12, 2025

Conversation

LouiseHsu
Copy link
Contributor

Make Storekit 2 the default. Fixes flutter/flutter#159871

Pre-Review Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter].
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or I have commented below to indicate which [version change exemption] this PR falls under[^1].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style], or I have commented below to indicate which [CHANGELOG exemption] this PR falls under[^1].
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
  • All existing and new tests are passing.

@LouiseHsu LouiseHsu requested a review from hellohuanlin April 29, 2025 23:44
@hellohuanlin
Copy link
Contributor

I saw you requested review but it's still "Draft" mode. is it ready to review?

hellohuanlin
hellohuanlin reviewed Apr 30, 2025
View reviewed changes
packages/in_app_purchase/in_app_purchase_storekit/CHANGELOG.md
@@ -1,3 +1,7 @@
## 0.3.23

* **BREAKING CHANGE:** StoreKit 2 is now the default for all devices that support it.
Copy link
Contributor

@hellohuanlin hellohuanlin Apr 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be 0.4.0 instead? iirc breaking change should be major bump, but this is still 0. version, so a minor bump?
(cc @stuartmorgan-g for advice)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, breaking changes need a "major" (which for pre-1.0 is the second number, per Dart convention) version bump.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh makes sense. Ive changed it.

@LouiseHsu
Copy link
Contributor Author

I saw you requested review but it's still "Draft" mode. is it ready to review?

Now it is! Just had to make sure the tests were passing

@LouiseHsu LouiseHsu marked this pull request as ready for review May 1, 2025 19:02
@LouiseHsu LouiseHsu marked this pull request as draft May 2, 2025 19:45
@LouiseHsu LouiseHsu marked this pull request as ready for review May 6, 2025 21:38
hellohuanlin
hellohuanlin reviewed May 6, 2025
View reviewed changes
@LouiseHsu LouiseHsu requested a review from hellohuanlin May 8, 2025 19:38
hellohuanlin
hellohuanlin approved these changes May 12, 2025
View reviewed changes
...ages/in_app_purchase/in_app_purchase_storekit/lib/src/in_app_purchase_storekit_platform.dart Outdated
}

/// Call this before `registerPlatform` to re-enable StoreKit1
static bool enableStoreKit1() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we also deprecate this with a message that storekit 1 will be removed in the future (if that's the plan).

@LouiseHsu LouiseHsu added the autosubmit Merge PR when tree becomes green via auto submit App label May 12, 2025
@auto-submit auto-submit bot merged commit 2e166de into flutter:main May 12, 2025
82 checks passed
@stuartmorgan-g
Copy link
Collaborator

stuartmorgan-g commented May 13, 2025 •
edited
Loading

Was this intended to be split into two separate PRs? The changelog says "Updates in_app_purchase_storekit to 0.4.0", but the PR doesn't actually make that dependency change (and couldn't have in the same PR as in_app_purchase_storekit 0.4.0 was created).

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 13, 2025
@engine-flutter-autoroll
2e166de09 [in_app_purchase_storekit] Make Storekit 2 the default (flu…
01d036b 
…tter/packages#9178)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2025
Merged
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request May 13, 2025
@engine-flutter-autoroll
Roll Packages from 6a28ad9419b1 to 2e166de09348 (2 revisions) (#168736)
36d28cc 
flutter/packages@6a28ad9...2e166de

2025-05-12 louisehsu@google.com [in_app_purchase_storekit] Make Storekit
2 the default (flutter/packages#9178)
2025-05-12 engine-flutter-autoroll@skia.org Roll Flutter from
992ad74 to 54de32d (7 revisions) (flutter/packages#9243)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@LouiseHsu
Copy link
Contributor Author

Was this intended to be split into two separate PRs? The changelog says "Updates in_app_purchase_storekit to 0.4.0", but the PR doesn't actually make that dependency change (and couldn't have in the same PR as in_app_purchase_storekit 0.4.0 was created).

I might be misunderstanding? I thought I updated the pubspec to 0.4.0 here https://github.com/flutter/packages/pull/9178/files#diff-0c8b2973edeea37bde2da4d9d3c56b3754745fcf2bb2462dde0ac17d37b2343d

@stuartmorgan-g
Copy link
Collaborator

This PR created version 0.4.0 of in_app_purchase_storekit, but the line I quoted is from the in_app_purchase README, not the in_app_purchase_storekit README.

I would expect a release of foo that says it "updates foo_some_platform to version X" to set a dependency of foo_some_platform: ^X in foo/pubspec.yaml.

@LouiseHsu
Copy link
Contributor Author

This PR created version 0.4.0 of in_app_purchase_storekit, but the line I quoted is from the in_app_purchase README, not the in_app_purchase_storekit README.

I would expect a release of foo that says it "updates foo_some_platform to version X" to set a dependency of foo_some_platform: ^X in foo/pubspec.yaml.

ohhhhhhhh. 🤦‍♀️ so sorry, let me open a seperate pr for that.

@LouiseHsu LouiseHsu mentioned this pull request May 13, 2025
Merged
auto-submit bot pushed a commit that referenced this pull request May 14, 2025
@LouiseHsu
[in_app_purchase] Bump in_app_purchase_storekit version (#9247)
63843bb 
as per #9178 (comment)
@LouiseHsu LouiseHsu mentioned this pull request Jun 5, 2025
Closed
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@LouiseHsu @FMorschel
[in_app_purchase_storekit] Make Storekit 2 the default (flutter#9178)
9ad8001 
Make Storekit 2 the default. Fixes flutter/flutter#159871

## Pre-Review Checklist
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@LouiseHsu @FMorschel
[in_app_purchase] Bump in_app_purchase_storekit version (flutter#9247)
8e0f585 
as per flutter#9178 (comment)
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
@LouiseHsu @Ortes
[in_app_purchase_storekit] Make Storekit 2 the default (flutter#9178)
fb0a9f0 
Make Storekit 2 the default. Fixes flutter/flutter#159871

## Pre-Review Checklist
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
@LouiseHsu @Ortes
[in_app_purchase] Bump in_app_purchase_storekit version (flutter#9247)
8cd0e76 
as per flutter#9178 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g left review comments

@hellohuanlin hellohuanlin hellohuanlin approved these changes

@LongCatIsLooong LongCatIsLooong Awaiting requested review from LongCatIsLooong LongCatIsLooong is a code owner

@bparrishMines bparrishMines Awaiting requested review from bparrishMines bparrishMines is a code owner

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: in_app_purchase platform-ios platform-macos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[in_app_purchase_storekit] Make StoreKit2 the default for all supported devices.
3 participants
@LouiseHsu @hellohuanlin @stuartmorgan-g