Skip to content

Conversation

bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Dec 19, 2023

Added test in response to feedback from #5454 (review)

Also regenerates mock files.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@bparrishMines bparrishMines changed the title test for cancel default [webview_flutter_android] Add test that onAuthRequest is cancelled by default Dec 19, 2023
@bparrishMines bparrishMines changed the title [webview_flutter_android] Add test that onAuthRequest is cancelled by default [webview_flutter_android] Add test that onReceivedHttpAuthRequest is cancelled by default Dec 19, 2023
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bparrishMines bparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 13, 2024
@auto-submit auto-submit bot merged commit dea6c73 into flutter:main Jan 13, 2024
@bparrishMines bparrishMines deleted the auth_android_test branch January 13, 2024 22:24
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 15, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 15, 2024
flutter/packages@d74d687...d21f3b8

2024-01-14 engine-flutter-autoroll@skia.org Roll Flutter from 7dc856a to 1a2c315 (23 revisions) (flutter/packages#5895)
2024-01-13 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android] Add test that `onReceivedHttpAuthRequest` is cancelled by default  (flutter/packages#5723)
2024-01-13 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 46787ee to ef1af02 (1 revision) (flutter/packages#5887)
2024-01-12 stuartmorgan@google.com [google_maps_flutter] Drop iOS 11 support (flutter/packages#5873)
2024-01-12 engine-flutter-autoroll@skia.org Roll Flutter from 9f2e681 to 7dc856a (15 revisions) (flutter/packages#5882)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
sybrands-place pushed a commit to sybrands-place/packages that referenced this pull request Jan 16, 2024
* main: (186 commits)
  Roll Flutter from 7dc856a to 1a2c315 (23 revisions) (flutter#5895)
  [webview_flutter_android] Add test that `onReceivedHttpAuthRequest` is cancelled by default  (flutter#5723)
  Roll Flutter (stable) from 46787ee49c1f to ef1af02aead6 (1 revision) (flutter#5887)
  [google_maps_flutter] Drop iOS 11 support (flutter#5873)
  Roll Flutter from 9f2e681 to 7dc856a (15 revisions) (flutter#5882)
  [ci] Check repo-level package metadata (flutter#5811)
  [various] Add iOS privacy manifests (flutter#5846)
  [video_player] Skip flaky tests in certain circumstances on Android (flutter#5872)
  Roll Flutter (stable) from 78666c8dc57e to 46787ee49c1f (5 revisions) (flutter#5870)
  Roll Flutter from b840a60 to 9f2e681 (24 revisions) (flutter#5871)
  [quick_actions_android] Close system dialogs for integration test (flutter#5853)
  [file_selector]: Bump androidx.annotation:annotation from 1.7.0 to 1.7.1 in /packages/file_selector/file_selector_android/android (flutter#5712)
  [in_app_pur]: Bump androidx.annotation:annotation from 1.7.0 to 1.7.1 in /packages/in_app_purchase/in_app_purchase_android/android (flutter#5713)
  [url_launcher]: Bump androidx.annotation:annotation from 1.7.0 to 1.7.1 in /packages/url_launcher/url_launcher_android/android (flutter#5708)
  [image_picker]: Bump androidx.annotation:annotation from 1.7.0 to 1.7.1 in /packages/image_picker/image_picker_android/android (flutter#5703)
  Roll Flutter from 126302d to b840a60 (29 revisions) (flutter#5855)
  Roll Flutter from c6ddb73 to 126302d (32 revisions) (flutter#5852)
  Bump github/codeql-action from 3.22.12 to 3.23.0 (flutter#5849)
  Re-land: Enable prefer_mixin and bump plugin_platform_interface to 2.1.7 (flutter#5841)
  [ci] Exclude quick_actions from Android emulators (flutter#5847)
  ...

# Conflicts:
#	packages/webview_flutter/webview_flutter_wkwebview/ios/Classes/FWFNavigationDelegateHostApi.m
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: webview_flutter platform-android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants