Skip to content

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Nov 12, 2021

iOS apps can be ad-hoc codesigned (signed without a developer cert, and instead with identity -), which allows them to run on simulators, but not real devices. We use ad-hoc codesigning for host-only simulator tests on machines where the developer cert is not set up:

'CODE_SIGNING_ALLOWED=NO',
'CODE_SIGNING_REQUIRED=NO',
'CODE_SIGN_IDENTITY=-',
'EXPANDED_CODE_SIGN_IDENTITY=-',

When the Flutter.framework is codesigned (every channel but master), the app will crash on launch because the framework is codesigned differently (not ad-hoc) than the app. This manifests in dev/beta/release cherry-pick tests because the framework is codesigned, but not on master.
Instead of skipped codesigning the framework in this case, instead ad-hoc codesign with identity -.

Fixes #93517

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Nov 12, 2021
@google-cla google-cla bot added the cla: yes label Nov 12, 2021
@jmagman jmagman changed the title Ad-hoc codesign Flutter.framework Ad-hoc codesign Flutter.framework when code signing is disabled Nov 12, 2021
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.8 beta release blocked on ios app crash
3 participants