Ad-hoc codesign Flutter.framework when code signing is disabled #93556
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iOS apps can be ad-hoc codesigned (signed without a developer cert, and instead with identity
-
), which allows them to run on simulators, but not real devices. We use ad-hoc codesigning for host-only simulator tests on machines where the developer cert is not set up:flutter/dev/devicelab/bin/tasks/module_test_ios.dart
Lines 258 to 261 in 0c81077
When the Flutter.framework is codesigned (every channel but master), the app will crash on launch because the framework is codesigned differently (not ad-hoc) than the app. This manifests in dev/beta/release cherry-pick tests because the framework is codesigned, but not on master.
Instead of skipped codesigning the framework in this case, instead ad-hoc codesign with identity
-
.Fixes #93517
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.