Skip to content

Deprecate primaryColorBrightness #93396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Nov 16, 2021
Merged

Deprecate primaryColorBrightness #93396

merged 10 commits into from
Nov 16, 2021

Conversation

guidezpl
Copy link
Member

@guidezpl guidezpl commented Nov 10, 2021 •
edited
Loading

In line with https://flutter.dev/go/material-theme-system-updates and #91772, deprecates primaryColorBrightness. Usages in AppBar and TextField are removed.

A Dart fix is provided.

This is not a breaking change, per our policy. However, should this causes any issues, the documentation for primaryColorBrightness explains alternatives for its former usages.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. labels Nov 10, 2021
@google-cla google-cla bot added the cla: yes label Nov 10, 2021
@guidezpl
Copy link
Member Author

guidezpl commented Nov 10, 2021 •
edited
Loading

@HansMuller Can you please review before I write a breaking change doc?

Update: not a breaking change

HansMuller
HansMuller approved these changes Nov 10, 2021
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guidezpl guidezpl mentioned this pull request Nov 11, 2021
Open
42 tasks
@guidezpl guidezpl marked this pull request as ready for review November 11, 2021 14:31
@guidezpl guidezpl requested a review from HansMuller November 11, 2021 15:23
Piinks
Piinks approved these changes Nov 15, 2021
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for writing dart fixes for this! :)

HansMuller
HansMuller approved these changes Nov 15, 2021
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well.

@fluttergithubbot fluttergithubbot merged commit e1a96b8 into flutter:master Nov 16, 2021
@guidezpl guidezpl deleted the deprecate-primarycolorbrightness branch November 17, 2021 08:46
WizzXu pushed a commit to WizzXu/flutter that referenced this pull request Nov 19, 2021
@guidezpl @WizzXu
Deprecate primaryColorBrightness (flutter#93396)
18223c5
@gspencergoog gspencergoog mentioned this pull request May 19, 2023
Merged
auto-submit bot pushed a commit that referenced this pull request May 26, 2023
@gspencergoog
Remove references to deprecated ThemeData.primaryColorBrightness (#…
0da6f04 
…127238)

## Description

Removes references to `ThemeData.primaryColorBrightness`, deprecated in #93396 and subject to remove now because of our [deprecation policy](https://github.com/flutter/flutter/wiki/Tree-hygiene#deprecations).

## Related PRs
 - #93396

## Tests
 - Removed unneeded tests, removed references.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piinks Piinks Piinks approved these changes

+1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
a: text input Entering text in a text field or keyboard related problems c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guidezpl @HansMuller @Piinks @fluttergithubbot