-
Notifications
You must be signed in to change notification settings - Fork 29.1k
Expose the leader field of the LayerLink class. #96451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
…d back to the class
I took another look at this and I believe we can simplify the LeaderLayer even further, which will also allow us to bring back the |
local_hero may want to consider adding itself to |
Adding test to |
No, that will not help :). Packages can contribute their tests to https://github.com/flutter/tests as explained in the readme over there: https://github.com/flutter/tests/blob/master/README.md. That gives us a signal whether our changes break anything in the real world and if it does we will either reconsider the change or provide a breaking change announcement with migration guide. |
@goderbauer I do not understand - #92598 was merged last year and this PR was opened 17 days ago - how can this have been closed in favor of #92598 when this PR is only a follow-up? Is there anything wrong with this change ~ |
I accidentally linked to the wrong PR in that comment. Meant to link to #96486, which re-exposes the leader field in a cleaner way. |
@goderbauer thanks! ❤️ |
Some packages, like local_hero, need to access
LayerLink.leader
in order to work.LeaderLayer? get leader => _leader
is added to the LayerLink class again.Pre-launch Checklist
///
).