-
Notifications
You must be signed in to change notification settings - Fork 29.2k
[flutter_tools] increase windows tool_integration_tests shard #95917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flutter_tools] increase windows tool_integration_tests shard #95917
Conversation
@@ -3893,7 +3893,7 @@ targets: | |||
- bin/** | |||
- .ci.yaml | |||
|
|||
- name: Windows tool_integration_tests_1_5 | |||
- name: Windows tool_integration_tests_1_6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This unfortunately still shows some of the pain with having to roll into the LUCI configs. We need to duplicate these builders with bringup: true, then land a separate commit to remove the label
Once we move flutter/infra to a generic builder we can get around this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean leave tool_integration_tests_1_5
as blocking and add tool_integration_tests_1_6
as bringup? and then after it rolls to the builder config, delete the old ones and mark the new ones as blocking?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Post-submit will seem like there are duplicates, which is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filed #96544 to track the follow-up PR
66e0577
to
64db7ff
Compare
@CaseyHillers could you take another look? CI failures are unrelated CDN network failures: #96550 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…ool-integration-shard
increase windows tool_integration_tests shards from 5 -> 6 to fix #95584 (tests are just at the timeout limit now)