Skip to content

Conversation

christopherfujino
Copy link
Contributor

increase windows tool_integration_tests shards from 5 -> 6 to fix #95584 (tests are just at the timeout limit now)

@@ -3893,7 +3893,7 @@ targets:
- bin/**
- .ci.yaml

- name: Windows tool_integration_tests_1_5
- name: Windows tool_integration_tests_1_6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This unfortunately still shows some of the pain with having to roll into the LUCI configs. We need to duplicate these builders with bringup: true, then land a separate commit to remove the label

Once we move flutter/infra to a generic builder we can get around this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean leave tool_integration_tests_1_5 as blocking and add tool_integration_tests_1_6 as bringup? and then after it rolls to the builder config, delete the old ones and mark the new ones as blocking?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Post-submit will seem like there are duplicates, which is fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed #96544 to track the follow-up PR

@goderbauer goderbauer added c: contributor-productivity Team-specific productivity, code health, technical debt. team-infra Owned by Infrastructure team labels Jan 5, 2022
@christopherfujino christopherfujino force-pushed the increase-window-tool-integration-shard branch from 66e0577 to 64db7ff Compare January 12, 2022 20:08
@christopherfujino
Copy link
Contributor Author

@CaseyHillers could you take another look?

CI failures are unrelated CDN network failures: #96550

Copy link
Contributor

@CaseyHillers CaseyHillers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flutter-lgtm

@fluttergithubbot fluttergithubbot merged commit c13d441 into flutter:master Jan 14, 2022
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. team-infra Owned by Infrastructure team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows tool_integration_tests_1_5 is 3.00% flaky
4 participants