Skip to content

Revert "Constrain width/hight when asking child for intrinsics" #72102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2020
Merged

Revert "Constrain width/hight when asking child for intrinsics" #72102

merged 1 commit into from
Dec 11, 2020

Conversation

goderbauer
Copy link
Member

@goderbauer goderbauer commented Dec 10, 2020 •
edited
Loading

Reverts #71880

Reopens #27293

It's breaking tests in google and needs more investigation.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Dec 10, 2020
@google-cla google-cla bot added the cla: yes label Dec 10, 2020
@goderbauer goderbauer mentioned this pull request Dec 10, 2020
Open
@goderbauer goderbauer requested a review from Piinks December 10, 2020 23:44
Piinks
Piinks approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer
Copy link
Member Author

When this is re-applied, #72095 should be integrated into the fix as well.

@goderbauer goderbauer force-pushed the revert-71880-fixsizedboxintrinsics branch from 628bbcf to 50b3d22 Compare December 10, 2020 23:55
@goderbauer goderbauer merged commit 8df5605 into master Dec 11, 2020
@goderbauer goderbauer deleted the revert-71880-fixsizedboxintrinsics branch December 11, 2020 01:03
@goderbauer goderbauer mentioned this pull request Dec 11, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piinks Piinks Piinks approved these changes

Assignees
No one assigned
Labels
framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goderbauer @Piinks