Skip to content

Conversation

goderbauer
Copy link
Member

Description

Follow-up to #71880. I missed the case where _additionalConstraints specify a min width/height of infinity (meaning that the box should be as big as the parent allows).

Related Issues

#27293
b/175263631

Tests

I added the following tests:

  • test when dimension is infinity

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Dec 10, 2020
@google-cla google-cla bot added the cla: yes label Dec 10, 2020
@Piinks Piinks self-requested a review December 10, 2020 22:28
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@goderbauer
Copy link
Member Author

CLosing for now since the change this is based on got reverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants