Always write full timeline before summary #79310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would like to land this even if the tree is red, but I would like to land it after the CL that starts uploading timelines to luci. |
|
We apparently have customer(s) using this API, so I'm deprecating it instead of removing it. |
zanderso
approved these changes
Mar 29, 2021
|
(I will land this as long as flutter-build is the only thing that's red) |
|
Blocked by flutter/gallery#469 |
|
Blocked by #79310 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timeline API for the devicelab currently expects tests to separately call writing the full timeline and the summary. The order of these is important, since summarizing can fail if no frames were produced. However, it's always beneficial to write the full timeline first in that case so that we can still try to figure out what, if anything, showed up in the timeline.
Expected to help with #79097 and some related issues, particularly with large_image_changer which had this in the wrong order.
I will be filing a separate CL to update the recipe to set an env var so these get picked up by luci.
@zanderso @jmagman @godofredoc