Skip to content

[versions] roll to latest test #79099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 31, 2021
Merged

[versions] roll to latest test #79099

merged 5 commits into from
Mar 31, 2021

Conversation

jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Mar 25, 2021 •
edited
Loading

Fixes #77856

Roll to latest package:test, test_core, test_api

@jonahwilliams jonahwilliams requested a review from Piinks as a code owner March 25, 2021 23:14
@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Mar 25, 2021
@google-cla google-cla bot added the cla: yes label Mar 25, 2021
@jmagman
Copy link
Member

jmagman commented Mar 25, 2021 

  error • A value of type 'String?' can't be assigned to a variable of type 'String' • packages/flutter_test/test/widget_tester_test.dart:76:30 • invalid_assignment
  error • A value of type 'String?' can't be assigned to a variable of type 'String' • packages/flutter_test/test/widget_tester_test.dart:99:30 • invalid_assignment
  error • A value of type 'String?' can't be assigned to a variable of type 'String' • packages/flutter_test/test/widget_tester_test.dart:117:30 • invalid_assignment

@jonahwilliams
Copy link
Contributor Author

So this can't actually land, until we figure out what we want to do about the version change.

@jonahwilliams jonahwilliams marked this pull request as draft March 25, 2021 23:58
@flutter-dashboard
Copy link

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@jonahwilliams jonahwilliams mentioned this pull request Mar 29, 2021
Merged
jonahwilliams pushed a commit to flutter/packages that referenced this pull request Mar 29, 2021
Allow web_benchmarks to depend on webkit_inspection_protocol 1.0
cb014b5 
Towards flutter/flutter#79099
@jonahwilliams jonahwilliams mentioned this pull request Mar 29, 2021
Merged
@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Mar 29, 2021
@jonahwilliams jonahwilliams marked this pull request as ready for review March 29, 2021 20:36
@jonahwilliams jonahwilliams requested a review from zanderso March 29, 2021 20:37
@jonahwilliams
Copy link
Contributor Author

all dependencies are updated

@jonahwilliams jonahwilliams mentioned this pull request Mar 30, 2021
Merged
@jonahwilliams
Copy link
Contributor Author

Now blocked by flutter/plugins#3769

@jonahwilliams
Copy link
Contributor Author

Looks like its all going to pass

@jonahwilliams jonahwilliams merged commit 443d07b into flutter:master Mar 31, 2021
@jonahwilliams jonahwilliams deleted the asd78q21d12diasdjasd9das9a branch March 31, 2021 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanderso zanderso zanderso approved these changes

@Piinks Piinks Awaiting requested review from Piinks

Assignees
No one assigned
Labels
a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flutter SDK's test deps are stuck due to vm_snapshot_analysis, devtools_server
3 participants
@jonahwilliams @jmagman @zanderso