Skip to content

Make the launch background drawable compatible with older Android API levels #69255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2020
Merged

Make the launch background drawable compatible with older Android API levels #69255

merged 1 commit into from
Nov 3, 2020

Conversation

jason-simmons
Copy link
Member

The #65182 change introduced a
drawable with a reference to a theme attribute. Loading this requires
a Resources.getDrawable API introduced in API level 21.

@jason-simmons jason-simmons requested a review from xster October 28, 2020 23:40
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Oct 28, 2020
@google-cla google-cla bot added the cla: yes label Oct 28, 2020
@jason-simmons jason-simmons force-pushed the launch_background_api21 branch from 5187072 to 1d9081a Compare October 30, 2020 18:23
@jason-simmons jason-simmons requested a review from blasten November 2, 2020 21:17
@jason-simmons
Make the launch background drawable compatible with older Android API…
2b0c5dd 
… levels

The flutter#65182 change introduced a
drawable with a reference to a theme attribute.  Loading this requires
a Resources.getDrawable API introduced in API level 21.
@jason-simmons jason-simmons force-pushed the launch_background_api21 branch from 1d9081a to 2b0c5dd Compare November 2, 2020 21:18
blasten
blasten approved these changes Nov 2, 2020
View reviewed changes
Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 88bf732 into flutter:master Nov 3, 2020
@xster
Copy link
Member

xster commented Nov 3, 2020

Thanks Jason

@itsarjunsinh itsarjunsinh mentioned this pull request Apr 19, 2021
Closed
8 tasks
@itsarjunsinh itsarjunsinh mentioned this pull request May 12, 2021
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xster xster Awaiting requested review from xster

1 more reviewer

@blasten blasten blasten approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jason-simmons @xster @blasten @fluttergithubbot