Apply darkmode style #65182
Merged
Apply darkmode style #65182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
2ab212f to
59f685d
Compare
|
@xster sorry for mentioning, but could you check out my PR? Thanks |
xster
approved these changes
Sep 11, 2020
packages/flutter_tools/templates/app/android.tmpl/app/src/main/res/values/styles.xml
Show resolved
Hide resolved
packages/flutter_tools/templates/app/android.tmpl/app/src/main/res/values-night/styles.xml
Outdated
Show resolved
Hide resolved
packages/flutter_tools/templates/app/android.tmpl/app/src/main/res/values-night/styles.xml
Outdated
Show resolved
Hide resolved
6ee9207 to
b7b0e0e
Compare
goderbauer
pushed a commit
to goderbauer/flutter
that referenced
this pull request
Sep 18, 2020
jason-simmons
added a commit
to jason-simmons/flutter
that referenced
this pull request
Nov 2, 2020
… levels The flutter#65182 change introduced a drawable with a reference to a theme attribute. Loading this requires a Resources.getDrawable API introduced in API level 21.
8 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add darkmode style to the template so that the launch background is applied according to the current theme
Related Issues
resolved #42710
Tests
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.