Skip to content

[WIP] Migrate Gallery benchmarks, Version 3 (flutter side) #66911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 45 commits into from

Conversation

pennzht
Copy link
Member

@pennzht pennzht commented Sep 29, 2020

Description

This PR moves Gallery web benchmarks out of Flutter proper and separates the dependencies for flutter/flutter and flutter/gallery, allowing the two repos to freely update dependencies in the future, while preserving the important benchmarks which give us tons of useful signals, not just performance, but stability also.

These two PRs (see References section below) behave in the following way:

  1. flutter side — Creates a new package web_benchmarks inside packages, and updates existing web benchmarks to use this package. Also rewrites Gallery benchmarks in flutter/flutter to stop using pubspec.yaml dependencies, and start pulling flutter/gallery at runtime.
  2. gallery side — Adds Gallery benchmarks (browser side) to the flutter/gallery, using the newly created web_benchmarks package.

The two PRs must be landed in this order.

Currently, some dependencies / git references are pointing to my own branches. They will be moved to official branches once the corresponding prerequisites are landed.

References

Flutter side — #66911
Gallery side — flutter/gallery#333

Related Issues

Replace this paragraph with a list of issues related to this PR from our issue database. Indicate, which of these issues are resolved or fixed by this PR. There should be at least one issue listed here.

Tests

No tests are added here.
Tests are added for the web_benchmarks package.

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. c: contributor-productivity Team-specific productivity, code health, technical debt. work in progress; do not review labels Sep 29, 2020
@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • Please get at least one approved review before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.
  • The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux docs has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux web_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite analyze-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite docs-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite deploy_gallery-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite deploy_gallery-macos has failed. Please fix the issues identified (or deflake) before re-applying this label.

@goderbauer
Copy link
Member

Are there still plans for this or should we close this PR?

@Hixie
Copy link
Contributor

Hixie commented Nov 17, 2021

Since there has been no progress here for a few weeks and the PR is marked "draft", I'm going to close the PR for now. Please do not hesitate to create a new PR when this is ready to land! Thanks!

@Hixie Hixie closed this Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. f: material design flutter/packages/flutter/material repository.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants