-
Notifications
You must be signed in to change notification settings - Fork 29k
[WIP] Migrate Gallery benchmarks, Version 3 (flutter side) #66911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is not suitable for automatic merging in its current state.
|
Are there still plans for this or should we close this PR? |
Since there has been no progress here for a few weeks and the PR is marked "draft", I'm going to close the PR for now. Please do not hesitate to create a new PR when this is ready to land! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: contributor-productivity
Team-specific productivity, code health, technical debt.
f: material design
flutter/packages/flutter/material repository.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves Gallery web benchmarks out of Flutter proper and separates the dependencies for
flutter/flutter
andflutter/gallery
, allowing the two repos to freely update dependencies in the future, while preserving the important benchmarks which give us tons of useful signals, not just performance, but stability also.These two PRs (see References section below) behave in the following way:
web_benchmarks
insidepackages
, and updates existing web benchmarks to use this package. Also rewrites Gallery benchmarks influtter/flutter
to stop usingpubspec.yaml
dependencies, and start pullingflutter/gallery
at runtime.flutter/gallery
, using the newly createdweb_benchmarks
package.The two PRs must be landed in this order.
Currently, some dependencies / git references are pointing to my own branches. They will be moved to official branches once the corresponding prerequisites are landed.
References
Flutter side — #66911
Gallery side — flutter/gallery#333
Related Issues
Replace this paragraph with a list of issues related to this PR from our issue database. Indicate, which of these issues are resolved or fixed by this PR. There should be at least one issue listed here.
Tests
No tests are added here.
Tests are added for the
web_benchmarks
package.Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze --flutter-repo
) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.