Skip to content

Reland: TextSelectionTheme support (step 2 of 3) #66061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2020
Merged

Reland: TextSelectionTheme support (step 2 of 3) #66061

merged 1 commit into from
Sep 17, 2020

Conversation

darrenaustin
Copy link
Contributor

The original PR: #65044 was reverted due to a problem with the gold image system. Now that it has been resolved, this attempts to land it again.

@darrenaustin
Reland ##65044
02fa3f1 
Turn the opt-in default for ThemeData.useTextSelectionTheme to true so that everything uses the new TextSelectionTheme by default.
@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Sep 17, 2020
@skia-gold
Copy link

Gold has detected about 6 untriaged digest(s) on patchset 1.
View them at https://flutter-gold.skia.org/cl/github/66061

justinmc
justinmc approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Is this part of the process for fixing the skia gold bot comments like the one on this PR?

@darrenaustin darrenaustin merged commit 1f62776 into flutter:master Sep 17, 2020
@darrenaustin
Copy link
Contributor Author

Is this part of the process for fixing the skia gold bot comments like the one on this PR?

No Kate already fixed gold. The problem was while it was broken, my original PR had broke the tree due to an image not being approved. Jonah reverted it to get the tree back to green. This is just a relanding now that gold has been fixed.

@darrenaustin darrenaustin deleted the text_selection_theme_opt_in_reland branch September 18, 2020 00:37
@justinmc
Copy link
Contributor

Got it, thanks!

goderbauer pushed a commit to goderbauer/flutter that referenced this pull request Sep 18, 2020
@darrenaustin @goderbauer
Reland #flutter#65044 (flutter#66061)
1e2a627 
Turn the opt-in default for ThemeData.useTextSelectionTheme to true so that everything uses the new TextSelectionTheme by default.
@darrenaustin darrenaustin mentioned this pull request Sep 23, 2020
Merged
13 tasks
@darrenaustin darrenaustin mentioned this pull request Oct 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmc justinmc justinmc approved these changes

@HansMuller HansMuller Awaiting requested review from HansMuller

Assignees
No one assigned
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@darrenaustin @skia-gold @justinmc @googlebot