Skip to content

Conversation

jonahwilliams
Copy link
Contributor

Reverts #65044

Trying to rule out this PR as the cause of the cull_opacity_perf__timeline_summary timeout. Fyi @darrenaustin

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Sep 17, 2020
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@jonahwilliams jonahwilliams merged commit a3aeab0 into master Sep 17, 2020
@jonahwilliams jonahwilliams deleted the revert-65044-text_selection_theme_opt_in branch September 17, 2020 18:43
@darrenaustin
Copy link
Contributor

Wow, sorry I missed this. I am not sure what I did wrong with gold, but I will take a look and make sure I don't do it again. Thanks for dealing with this.

goderbauer pushed a commit to goderbauer/flutter that referenced this pull request Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants