Skip to content

Revert "Roll new gallery to help flaky Crane test" #64824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2020

Conversation

zanderso
Copy link
Member

@zanderso zanderso commented Aug 28, 2020

Reverts #64676

A few device lab tests consistently red after this landed.

new_gallery_ios__transition_perf
ios_app_with_extensions_test
new_gallery_transition_perf

@zanderso zanderso requested a review from liyuqian August 28, 2020 20:53
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Aug 28, 2020
@zanderso
Copy link
Member Author

Landing revert on red.

@zanderso zanderso merged commit 6f02c0b into master Aug 28, 2020
@zanderso zanderso deleted the revert-64676-roll_new_gallery branch August 28, 2020 20:54
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants