Skip to content

Conversation

GaryQian
Copy link
Contributor

@GaryQian GaryQian commented Jan 2, 2019

This test will require an engine roll containing flutter/engine@54d7c42 to work.

@zoechi zoechi added a: tests "flutter test", flutter_test, or one of our tests engine flutter/engine related. See also e: labels. labels Jan 3, 2019
@GaryQian GaryQian requested a review from liyuqian January 3, 2019 20:47
GaryQian added a commit to flutter/goldens that referenced this pull request Jan 15, 2019
Copy link
Contributor

@liyuqian liyuqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GaryQian GaryQian merged commit fc779c6 into flutter:master Jan 16, 2019
kangwang1988 pushed a commit to XianyuTech/flutter that referenced this pull request Feb 12, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a: tests "flutter test", flutter_test, or one of our tests engine flutter/engine related. See also e: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants