Skip to content

Allow select cases to be numbers (#116625) #120847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2023
Merged

Allow select cases to be numbers (#116625) #120847

merged 1 commit into from
Feb 17, 2023

Conversation

AlexV525
Copy link
Member

(cherry picked from commit 583a812)

As a pre-cp of #120678 suggested at #120678 (comment).

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@AlexV525 AlexV525 requested a review from thkim1011 February 16, 2023 01:49
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 16, 2023
@AlexV525 AlexV525 mentioned this pull request Feb 16, 2023
Closed
thkim1011
thkim1011 approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@thkim1011 thkim1011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but just to make sure, cherry-picking the other commit on top of this one works without merge conflicts?

@AlexV525
Copy link
Member Author

LGTM but just to make sure, cherry-picking the other commit on top of this one works without merge conflicts?

I'm not sure I can fully understand your purpose, but after this has landed, we can rebase another request so it won't have conflicts then.

@AlexV525
Copy link
Member Author

@thkim1011 You'll need to approve the request issue too. :)

christopherfujino
christopherfujino approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itsjustkevin itsjustkevin merged commit a396cc3 into flutter:flutter-3.7-candidate.1 Feb 17, 2023
@AlexV525 AlexV525 deleted the cp-583a812 branch February 18, 2023 06:07
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
a396cc32f Allow select cases to be numbers (#116625) (flutter/flutter…
40b476e 
…#120847)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023
@engine-flutter-autoroll
a396cc32f Allow select cases to be numbers (#116625) (flutter/flutter…
21e0ea0 
…#120847)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
a396cc32f Allow select cases to be numbers (#116625) (flutter/flutter…
c946f73 
…#120847)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thkim1011 thkim1011 thkim1011 approved these changes

+1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexV525 @thkim1011 @christopherfujino @itsjustkevin