Add a way to customize padding in BottomAppBar #115175

hannah-hyj · 2022-11-11T20:42:46Z

Fixed: #114794

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

packages/flutter/lib/src/material/bottom_app_bar.dart

packages/flutter/test/material/bottom_app_bar_test.dart

HansMuller · 2022-11-14T23:31:14Z

It looks like a simple lint is still getting in the way of this PR:

flutter/test/material/bottom_app_bar_test.dart:99: trailing U+0020 space character

packages/flutter/lib/src/material/bottom_app_bar_theme.dart

packages/flutter/test/material/bottom_app_bar_test.dart

fix Update packages/flutter/lib/src/material/bottom_app_bar.dart lint update tests Co-Authored-By: Hans Muller <hansmuller@chromium.org>

HansMuller

LGTM

HansMuller · 2022-11-15T23:21:07Z

packages/flutter/test/material/bottom_app_bar_test.dart

@@ -85,6 +85,71 @@ void main() {
    );
  }, skip: isBrowser); // https://github.com/flutter/flutter/issues/44572

+
+  testWidgets('Custom Padding', (WidgetTester tester) async {
+  const EdgeInsets customPadding = EdgeInsets.all(10);


HansMuller · 2022-11-15T23:22:11Z

packages/flutter/test/material/bottom_app_bar_test.dart

+  });
+
+  testWidgets('Custom Padding in Material 3', (WidgetTester tester) async {
+  const EdgeInsets customPadding = EdgeInsets.all(10);


…er#115175)

* 338841a Revert "Revert "Revert "Scribble mixin (#104128)" (#114647)" (#114698)" (flutter/flutter#115146) * 229b39e [flutter_tools] Fix so that the value set by `--dart-define-from-file` can be passed to Gradle (flutter/flutter#114297) * 3895786 Revert "Load assets in flutter_test without turning event loop. (#115123)" (flutter/flutter#115156) * a6e3ec8 mark firebase test lab test flaky because of upstream infra issues (flutter/flutter#115178) * 8d808b5 Roll Flutter Engine from 7326e5b3354b to 329900fc85d6 (7 revisions) (flutter/flutter#115185) * 10dc566 Add drone_dimensions to devicelab_build_test. (flutter/flutter#115183) * 0a5b531 b6e45ae35 extend const_finder to allow skipping particular classes (flutter/engine#37257) (flutter/flutter#115189) * 0e9ee36 [web] Add `--local-web-sdk` flag and use precompiled platform kernels for dart2js and ddc (flutter/flutter#114639) * 9e314ff Make FutureBuilder handle SynchronousFuture correctly, reland SynchronousFuture usage in test assets (flutter/flutter#115173) * 673fd97 17d428e68 Roll Dart SDK from 2b6909ba35e5 to 190040da0bc8 (2 revisions) (flutter/engine#37536) (flutter/flutter#115191) * edcdb00 Roll Flutter Engine from 17d428e688a9 to 38c4f1d78630 (2 revisions) (flutter/flutter#115192) * 8772768 Roll Flutter Engine from 38c4f1d78630 to 1f0dd2c0f5bb (2 revisions) (flutter/flutter#115194) * 6ec2bd0 M3 Segmented Button widget (flutter/flutter#113723) * b7b6758 f3dfdf4cc Roll Skia from 3bbdd5bc54f2 to a727f7ac8a98 (1 revision) (flutter/engine#37544) (flutter/flutter#115196) * 94e753d Roll Flutter Engine from f3dfdf4ccf38 to e3b3950f0fab (3 revisions) (flutter/flutter#115200) * 61e927d e63c9443b [Impeller] Include the new primitive type in the pipeline hash (flutter/engine#37546) (flutter/flutter#115201) * c05d887 Roll Flutter Engine from e63c9443bc04 to 9500d8c4a4ce (2 revisions) (flutter/flutter#115212) * 1f82985 1c8c23754 Roll Fuchsia Linux SDK from xDY5B0-NZzq2idRNU... to IE4logHFoa8ZZQAw3... (flutter/engine#37554) (flutter/flutter#115214) * 61b3d5a a0d8cd68c Add a limit to the Gaussian blur downsampling curve (flutter/engine#37550) (flutter/flutter#115217) * 2bf64aa fd56b7ee8 Roll Fuchsia Mac SDK from j3vspnGJcQvIfsXXu... to iPqmEVwAbmYwPlh5a... (flutter/engine#37557) (flutter/flutter#115218) * 53ab17d Roll Flutter Engine from fd56b7ee87f0 to 1ae285897eae (2 revisions) (flutter/flutter#115220) * 4488166 d4e2188e9 [Impeller] Fix DrawPaint regression (flutter/engine#37561) (flutter/flutter#115222) * bf906e6 2bdeaf7d7 Fix inertia cancel event on macOS Ventura (flutter/engine#37067) (flutter/flutter#115226) * 1a19409 06c390470 Roll Fuchsia Mac SDK from iPqmEVwAbmYwPlh5a... to N-iOLgSVYYh_AfC7Q... (flutter/engine#37566) (flutter/flutter#115236) * 1a460cf 54795869b Roll Skia from c0f87aed019b to 38edf6197aa9 (1 revision) (flutter/engine#37567) (flutter/flutter#115239) * 8230ef5 Revert "[web] Add `--local-web-sdk` flag and use precompiled platform kernels for dart2js and ddc (#114639)" (flutter/flutter#115242) * 8994920 7269f2f91 Roll Skia from 38edf6197aa9 to 0f515e97d535 (1 revision) (flutter/engine#37571) (flutter/flutter#115244) * 7ac00f7 40b071c75 Roll Fuchsia Linux SDK from IE4logHFoa8ZZQAw3... to AE_mBWzdDqUvn4r1N... (flutter/engine#37572) (flutter/flutter#115247) * fa94a3c b63e6cf55 [Impeller] dont include sampler offset in float offset (flutter/engine#37573) (flutter/flutter#115248) * cb224d1 b7567b92c Roll Fuchsia Mac SDK from N-iOLgSVYYh_AfC7Q... to WYzUv6RnWjJpAiqYp... (flutter/engine#37575) (flutter/flutter#115252) * d587fe4 a1b5507e5 Add playground to demonstrate mask blur problems (flutter/engine#37574) (flutter/flutter#115260) * f5205b1 6f7447efa Roll Fuchsia Linux SDK from AE_mBWzdDqUvn4r1N... to dRHIZSishiboEHMdw... (flutter/engine#37577) (flutter/flutter#115266) * 2c4051f b077c1c46 Roll Dart SDK from 996fe4d7ea9a to 45b7433f9015 (1 revision) (flutter/engine#37578) (flutter/flutter#115271) * 0b5f3fd 743cec5ba Roll Skia from 0f515e97d535 to b2109e6bbbe7 (1 revision) (flutter/engine#37580) (flutter/flutter#115279) * 80bcc3a 035313ae2 Roll Dart SDK from 45b7433f9015 to 7cbcf48157cf (1 revision) (flutter/engine#37582) (flutter/flutter#115281) * fdd2fe4 036f8ea88 Roll Fuchsia Mac SDK from WYzUv6RnWjJpAiqYp... to XvXKIR_SSUfSyGwxe... (flutter/engine#37583) (flutter/flutter#115293) * 436fb4c c290de693 Roll Skia from b2109e6bbbe7 to 2ad14e25f6f7 (7 revisions) (flutter/engine#37585) (flutter/flutter#115294) * 2449907 Fixed the color curve issue (flutter/flutter#115188) * 9359c25 1a79e8686 [macOS] Move to new update semantics embedder API (flutter/engine#37404) (flutter/flutter#115301) * 59e1edc Roll Flutter Engine from 1a79e8686036 to 8c73ffff5b6f (2 revisions) (flutter/flutter#115302) * f2ec1c4 42bc762b6 Roll Skia from 2ad14e25f6f7 to a434f9b69660 (11 revisions) (flutter/engine#37591) (flutter/flutter#115304) * ea4e11d Fix test in preparation of the Dart VM dropping support for language versions < 2.12.0 (flutter/flutter#115176) * a0a7b3a 14ecaeb91 [Impeller] error earlier on uint types (flutter/engine#37593) (flutter/flutter#115308) * 2e51077 Do not strip architecture suffixes from host local-engine (flutter/flutter#115320) * 8e3ea14 Incorrect rendering of `SnapshotWidget` (flutter/flutter#114400) * 59ecc75 [flutter_tools] add uint compilation test (flutter/flutter#115317) * 1aeb172 Roll Flutter Engine from 14ecaeb915e0 to 78ae2414003a (10 revisions) (flutter/flutter#115335) * e391812 9dedab305 Roll Skia from b474a43dcc34 to 2cebc1ce363c (2 revisions) (flutter/engine#37612) (flutter/flutter#115338) * 9d64a0f 31ee28684 Combine results of all the test batches. (flutter/engine#37610) (flutter/flutter#115340) * e9c6212 [Impeller] Add shader include with FlutterFragCoord for use by FragmentProgram (flutter/flutter#114214) * a27bb3c 06bd5a816 Roll Skia from 2cebc1ce363c to d758b240cad0 (1 revision) (flutter/engine#37614) (flutter/flutter#115341) * abbffcc c6a513ecd Roll Fuchsia Mac SDK from XvXKIR_SSUfSyGwxe... to 32kfSm94FGtJJeUjg... (flutter/engine#37615) (flutter/flutter#115344) * 0f56ed1 f01de9f6b Roll Skia from d758b240cad0 to 24523449b1b3 (1 revision) (flutter/engine#37616) (flutter/flutter#115346) * 25d74e6 0b338ed86 Roll Dart SDK from 6f5478a58387 to 987faaf6d1d4 (2 revisions) (flutter/engine#37617) (flutter/flutter#115352) * 1f28f99 721fbe111 Roll Skia from 24523449b1b3 to 4d519a8ba97a (3 revisions) (flutter/engine#37618) (flutter/flutter#115354) * c37f255 [tools] Fix plugin_ffi template lint violation (flutter/flutter#115356) * 3c3f136 b4fd07fa4 Roll Dart SDK from 987faaf6d1d4 to 42f87c0521f8 (1 revision) (flutter/engine#37619) (flutter/flutter#115362) * 2ed5283 58495f077 [Impeller] Add debug names to additional VK objects (flutter/engine#37592) (flutter/flutter#115363) * afafde6 7f74f34a4 Roll Fuchsia Linux SDK from B0OuUvWOY24LI1WoF... to agStiOtzmc9Fmw6gc... (flutter/engine#37621) (flutter/flutter#115365) * af2ec91 Roll Plugins from 3ca3410 to e500884 (10 revisions) (flutter/flutter#115366) * 3a298d0 Roll Flutter Engine from 7f74f34a408a to eead7b0d8656 (2 revisions) (flutter/flutter#115369) * acf01eb 905862722 [dart] Run generate_sdk_version_file.py to be compatible with dart ch… (flutter/engine#37624) (flutter/flutter#115372) * 95ace11 Include initial offset when using PlatformViewSurface (flutter/flutter#114103) * 39a9ed5 Updated tokens to v0.141 (flutter/flutter#115298) * ba47c29 216702f3d Roll Skia from 1991515dd191 to 826b3ea577f3 (4 revisions) (flutter/engine#37628) (flutter/flutter#115377) * 2d77ac5 49f8326df Roll Skia from 826b3ea577f3 to 02e2101a75f7 (4 revisions) (flutter/engine#37631) (flutter/flutter#115385) * 136b46b Hint text semantics to be excluded in a11y read out if textfield in not empty and label text is provided (flutter/flutter#115010) * 700de09 Change button and label text to sentence case for Material 3 (flutter/flutter#115187) * b2b8391 Roll Flutter Engine from 49f8326df6f0 to 84cb1f833ac4 (3 revisions) (flutter/flutter#115387) * 2c44f4a Remove dev branch reference from build ios-frameworks error (flutter/flutter#115166) * 792eefe Roll Flutter Engine from 84cb1f833ac4 to af6e47f1d5c4 (4 revisions) (flutter/flutter#115395) * 341a9b1 6d41b2ffb update Scene.toImageSync test to use proper bounds in the request (flutter/engine#37638) (flutter/flutter#115398) * e66183d Bump github/codeql-action from 2.1.25 to 2.1.32 (flutter/flutter#115394) * d0e5b2f Add a way to customize padding in BottomAppBar (flutter/flutter#115175) * 349d648 baad8f2c5 Roll Skia from 02e2101a75f7 to cfb6de45f39b (7 revisions) (flutter/engine#37640) (flutter/flutter#115399) * 7d2b011 Fix logic error in `markNeedsPaint` (flutter/flutter#112735) * 93c4b09 Add `RestorableEnumN<T>` and `RestorableEnum<T>` to restorable primitive types (flutter/flutter#115050) * 2c1536a Create a main alias for master channel. (flutter/flutter#115388) * bbb349b Roll Flutter Engine from baad8f2c553b to e56ed93faab5 (6 revisions) (flutter/flutter#115406) * bacd770 c062f7ea7 Roll Skia from cfb6de45f39b to cdf8348e6fba (4 revisions) (flutter/engine#37649) (flutter/flutter#115407) * 27ff6a5 Roll Flutter Engine from c062f7ea7195 to 03e9a97f8abe (3 revisions) (flutter/flutter#115410) * 58728c6 Roll Flutter Engine from 03e9a97f8abe to 21a572e4e4d0 (2 revisions) (flutter/flutter#115411) * e54c8a8e2 3e15c1925 Roll Dart SDK from 7163c9627d98 to c3f1b3642181 (2 revisions) (flutter/engine#37664) (flutter/flutter#115417) * 484e09e Roll Flutter Engine from 3e15c192560f to 0241f18cbedf (2 revisions) (flutter/flutter#115423) * 4fdaf7a Revert "Roll Flutter Engine from 3e15c192560f to 0241f18cbedf (2 revisions) (#115423)" (flutter/flutter#115456) * 4301731 Make Flutter Driver actively wait for runnable isolate (flutter/flutter#113969) * c940f31 Marks Mac_ios flavors_test_ios to be unflaky (flutter/flutter#115458) * 243a830 Roll Flutter Engine from 3e15c192560f to 223e1f092dd5 (4 revisions) (flutter/flutter#115463) * d7454d5 removing default values for [reporter] and [timeout] in flutter test (flutter/flutter#115160) * a2233ea [flutter_tools] remove all body_might_complete_normally_catch_error ignores (flutter/flutter#115184) * b5345ff d72164776 Revert "[Impeller] Refactor color source resolution to use explicit factory types (#37656)" (flutter/engine#37673) (flutter/flutter#115467) * dcae424 [tools]build ipa validate template icon files (flutter/flutter#114841)

bernaferrari · 2022-11-17T02:39:27Z

packages/flutter/test/material/bottom_app_bar_test.dart

+    final  Rect babRect = tester.getRect(find.byType(BottomAppBar));
+    final  Rect childRect = tester.getRect(find.byType(ColoredBox));


This PR made a few mistakes on formatting: flutter#115175

bernaferrari · 2022-11-17T02:39:33Z

packages/flutter/test/material/bottom_app_bar_test.dart

+                alignment: Alignment.bottomCenter,
+                child: BottomAppBar(
+                  padding: customPadding,
+                    child:ColoredBox(


…er#115175)

This PR made a few mistakes on formatting: #115175

…er#115175)

* squash 5 into 1 fix Update packages/flutter/lib/src/material/bottom_app_bar.dart lint update tests Co-Authored-By: Hans Muller <hansmuller@chromium.org> * lint Co-authored-by: Hans Muller <hansmuller@chromium.org>

This PR made a few mistakes on formatting: flutter#115175

* squash 5 into 1 fix Update packages/flutter/lib/src/material/bottom_app_bar.dart lint update tests Co-Authored-By: Hans Muller <hansmuller@chromium.org> * lint Co-authored-by: Hans Muller <hansmuller@chromium.org>

This PR made a few mistakes on formatting: flutter#115175

flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Nov 11, 2022

hannah-hyj requested a review from darrenaustin November 11, 2022 20:43

HansMuller reviewed Nov 12, 2022

View reviewed changes

hannah-hyj requested a review from HansMuller November 14, 2022 22:26

HansMuller reviewed Nov 14, 2022

View reviewed changes

squash 5 into 1

e3b59b4

fix Update packages/flutter/lib/src/material/bottom_app_bar.dart lint update tests Co-Authored-By: Hans Muller <hansmuller@chromium.org>

hannah-hyj force-pushed the fix-114794 branch from 924454d to e3b59b4 Compare November 15, 2022 01:17

lint

8353b56

hannah-hyj requested a review from HansMuller November 15, 2022 22:31

HansMuller approved these changes Nov 15, 2022

View reviewed changes

hannah-hyj merged commit d0e5b2f into flutter:master Nov 15, 2022

engine-flutter-autoroll mentioned this pull request Nov 16, 2022

Roll Flutter from 098aac7ffeef to dcae424783db (92 revisions) flutter/packages#2818

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 16, 2022

d0e5b2f Add a way to customize padding in BottomAppBar (flutter/flutt…

86a9131

…er#115175)

bernaferrari reviewed Nov 17, 2022

View reviewed changes

bernaferrari added a commit to bernaferrari/flutter that referenced this pull request Nov 17, 2022

Fix formatting in BottomAppBar test

1d49e06

This PR made a few mistakes on formatting: flutter#115175

bernaferrari mentioned this pull request Nov 17, 2022

Fix formatting in BottomAppBar test #115520

Merged

bernaferrari reviewed Nov 17, 2022

View reviewed changes

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 17, 2022

d0e5b2f Add a way to customize padding in BottomAppBar (flutter/flutt…

caeee0f

…er#115175)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 18, 2022

d0e5b2f Add a way to customize padding in BottomAppBar (flutter/flutt…

fcbe724

…er#115175)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 18, 2022

d0e5b2f Add a way to customize padding in BottomAppBar (flutter/flutt…

10425e2

…er#115175)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 18, 2022

d0e5b2f Add a way to customize padding in BottomAppBar (flutter/flutt…

7d15d0b

…er#115175)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 18, 2022

d0e5b2f Add a way to customize padding in BottomAppBar (flutter/flutt…

3392be8

…er#115175)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 18, 2022

d0e5b2f Add a way to customize padding in BottomAppBar (flutter/flutt…

907a703

…er#115175)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 18, 2022

d0e5b2f Add a way to customize padding in BottomAppBar (flutter/flutt…

045aa06

…er#115175)

auto-submit bot pushed a commit that referenced this pull request Nov 18, 2022

Fix formatting in BottomAppBar test (#115520)

d2e6dfe

This PR made a few mistakes on formatting: #115175

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 18, 2022

d0e5b2f Add a way to customize padding in BottomAppBar (flutter/flutt…

4f5df4d

…er#115175)

shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022

Fix formatting in BottomAppBar test (flutter#115520)

67a1673

This PR made a few mistakes on formatting: flutter#115175

gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023

Fix formatting in BottomAppBar test (flutter#115520)

66e7d5c

This PR made a few mistakes on formatting: flutter#115175

chrisbobbe mentioned this pull request Mar 22, 2023

BottomAppBar: Fix doubled layers of color and shadow #123294

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add a way to customize padding in BottomAppBar #115175

Add a way to customize padding in BottomAppBar #115175

Uh oh!

hannah-hyj commented Nov 11, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

HansMuller commented Nov 14, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

HansMuller left a comment

Uh oh!

HansMuller Nov 15, 2022

Uh oh!

HansMuller Nov 15, 2022

Uh oh!

bernaferrari Nov 17, 2022

Uh oh!

bernaferrari Nov 17, 2022

Uh oh!

Uh oh!

		final Rect babRect = tester.getRect(find.byType(BottomAppBar));
		final Rect childRect = tester.getRect(find.byType(ColoredBox));

Add a way to customize padding in BottomAppBar #115175

Add a way to customize padding in BottomAppBar #115175

Uh oh!

Conversation

hannah-hyj commented Nov 11, 2022

Pre-launch Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

HansMuller commented Nov 14, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

HansMuller left a comment

Choose a reason for hiding this comment

Uh oh!

HansMuller Nov 15, 2022

Choose a reason for hiding this comment

Uh oh!

HansMuller Nov 15, 2022

Choose a reason for hiding this comment

Uh oh!

bernaferrari Nov 17, 2022

Choose a reason for hiding this comment

Uh oh!

bernaferrari Nov 17, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!