-
Notifications
You must be signed in to change notification settings - Fork 29.1k
Closed
Labels
f: material designflutter/packages/flutter/material repository.flutter/packages/flutter/material repository.found in release: 3.4Found to occur in 3.4Found to occur in 3.4frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.has reproducible stepsThe issue has been confirmed reproducible and is ready to work onThe issue has been confirmed reproducible and is ready to work onr: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer version
Description
Use case
Due to the change made by #114439 for BottomAppBar
my app designs are broken you can see below:
Material 2 | Material 3 |
---|---|
GitHub gist to reproduce the effect and DartPad link.
Flutter 3.5.0-12.0.pre.142 • channel master • https://github.com/flutter/flutter.git
Framework • revision c551fe3de1 (29 minutes ago) • 2022-11-07 01:32:24 -0500
Engine • revision 4e45cfb4a2
Tools • Dart 2.19.0 (build 2.19.0-374.0.dev) • DevTools 2.19.0
Proposal
Currently, in bottom_app_bar.dart
flutter is setting padding to the child like this when material 3 is active:
flutter/packages/flutter/lib/src/material/bottom_app_bar.dart
Lines 176 to 179 in c551fe3
final Widget? child = isMaterial3 ? Padding( | |
padding: const EdgeInsets.symmetric(vertical: 12.0, horizontal: 16.0), | |
child: widget.child, | |
) : widget.child; |
So, I think one solution for this is to provide an option to modify this padding set by material3 through BottomAppBar properties.
Metadata
Metadata
Assignees
Labels
f: material designflutter/packages/flutter/material repository.flutter/packages/flutter/material repository.found in release: 3.4Found to occur in 3.4Found to occur in 3.4frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.has reproducible stepsThe issue has been confirmed reproducible and is ready to work onThe issue has been confirmed reproducible and is ready to work onr: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer version