-
Notifications
You must be signed in to change notification settings - Fork 29.1k
Closed
Labels
f: material designflutter/packages/flutter/material repository.flutter/packages/flutter/material repository.frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.
Description
I want to update #99931 however there seem to be some token mishaps.
There is no color token for the dial container (There should be a surfaceVariant
token for this, onSurfaceVariant is the wrong color and it has .ignore
for some reason)
flutter/dev/tools/gen_defaults/data/time_picker.json
Lines 4 to 5 in 712860d
"md.comp.time-picker.clock-dial.color.ignore": "onSurfaceVariant", | |
"md.comp.time-picker.clock-dial.container.size": 256.0, |
Expected dial container color | There is no correct token, if clock-dial.color.ignore is used we get |
---|---|
Since the dial container suppose to have surfaceVariant
color, the selected text should be onPrimary
to be visible on dial hand with primary
color and unselected text should be onSurface
to be visible on surfaceVariant
dial background color.
Provided tokens are the opposite.
Selected dial text color (onSurface
is provided here to be on primary
color)
"md.comp.time-picker.clock-dial.selected.label-text.color": "onSurface", |
Unselected dial text color (onPrimary
is provided here to be on surfaceVariant
color)
"md.comp.time-picker.clock-dial.unselected.label-text.color": "onPrimary", |
If we apply these color tokens, dial colors are not as expected.
Preview |
---|
Metadata
Metadata
Assignees
Labels
f: material designflutter/packages/flutter/material repository.flutter/packages/flutter/material repository.frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.