-
Notifications
You must be signed in to change notification settings - Fork 29.2k
Migrate TimePicker
to Material 3
#99931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
TimerPicker
to Material 3TimePicker
to Material 3
636d91b
to
ac0ed7f
Compare
The red looks really out of place imo. I know you have specs but it's not clear which of PM or AM is selected there. |
I agree but as you said, this is just following Material 3 Specs |
@cedvdb It looks off in the official example as well. I certainly can't tell is it's supposed to be am or pm. I would even go as far as saying that the whole am pm section looks very out of place in general. None of the other examples on https://m3.material.io use color in a similar way to indicate a selected state. |
In your example I think it's more obvious that AM is selected, but with @TahaTesser example I'd have say it's PM even though I know with the context it's AM (because he posted m2 picture). The color used is very weird too but I assume it's just accent. Let's hope that color is overridable or that there is some communications between the flutter and m3 team |
@cedvdb now that you metion it: In the example by @TahaTesser the white part is supposed to indicate the selection. In the example from M3 I was assuming that black would have to indicate the selection, if it were to follow the same schema as the example here. |
We're waiting for official Material 3 specs for the Time picker and date picker so this migration can use Material 3 tokens. In current the state of the PR, I've simply copied color scheme from native implementation. This is not using tokens in Flutter right now. This will change after M3 specs are released or when tokens are available. |
|
I will file a new PR when specs and tokens are ready to use, see #105899 (comment) |
specs are available https://m3.material.io/components/time-pickers/overview, I will re-purpose this PR and migrate |
part of #91605
fixes #101480
minimal code sample
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.