This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Paint all backgrounds first to prevent overlap #7287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liyuqian
reviewed
Dec 22, 2018
|
Yes, I will add unit tests also, but both will probably go in the framework as we don't do pixel tests in the engine (yet) and this is only testable verifiable after paint. |
|
flutter/flutter#25988 contains golden tests for text paint order. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 3, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jan 3, 2019
flutter/engine@2940812...134b65e git log 2940812..134b65e --no-merges --oneline 134b65e Roll src/third_party/skia aae6ae39a356..fdde2926df92 (1 commits) (flutter/engine#7358) f97edf2 Roll src/third_party/skia 96345a23dfa9..aae6ae39a356 (1 commits) (flutter/engine#7357) d051c47 Roll src/third_party/skia bc84adceaada..96345a23dfa9 (2 commits) (flutter/engine#7356) 15fcba4 Roll src/third_party/skia d0d5bb8c8500..bc84adceaada (6 commits) (flutter/engine#7355) 4d353de Preparing to remove SK_SUPPORT_LEGACY_PAINT_TEXTMEASURE (flutter/engine#7354) 54d7c42 Paint all backgrounds first to prevent overlap (flutter/engine#7287) 0ad16dd Roll src/third_party/skia 279b65ddb5a3..d0d5bb8c8500 (12 commits) (flutter/engine#7353) 8cca33a Give more control over when dynamic patches get downloaded and installed. (flutter/engine#7327) 2d291c7 Roll src/third_party/skia 8f37ce5b9f2c..279b65ddb5a3 (6 commits) (flutter/engine#7350) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (amirha@chromium.org), and stop the roller if necessary.
kangwang1988
pushed a commit
to XianyuTech/flutter
that referenced
this pull request
Feb 12, 2019
flutter/engine@2940812...134b65e git log 2940812..134b65e --no-merges --oneline 134b65e Roll src/third_party/skia aae6ae39a356..fdde2926df92 (1 commits) (flutter/engine#7358) f97edf2 Roll src/third_party/skia 96345a23dfa9..aae6ae39a356 (1 commits) (flutter/engine#7357) d051c47 Roll src/third_party/skia bc84adceaada..96345a23dfa9 (2 commits) (flutter/engine#7356) 15fcba4 Roll src/third_party/skia d0d5bb8c8500..bc84adceaada (6 commits) (flutter/engine#7355) 4d353de Preparing to remove SK_SUPPORT_LEGACY_PAINT_TEXTMEASURE (flutter/engine#7354) 54d7c42 Paint all backgrounds first to prevent overlap (flutter/engine#7287) 0ad16dd Roll src/third_party/skia 279b65ddb5a3..d0d5bb8c8500 (12 commits) (flutter/engine#7353) 8cca33a Give more control over when dynamic patches get downloaded and installed. (flutter/engine#7327) 2d291c7 Roll src/third_party/skia 8f37ce5b9f2c..279b65ddb5a3 (6 commits) (flutter/engine#7350) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (amirha@chromium.org), and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes: flutter/flutter#24337
This addresses the background overlapping with the text part of the issue. The translucent backgrounds overlapping needs separate changes.