Skip to content
This repository was archived by the owner on Jun 13, 2024. It is now read-only.

Use light text theme for Fortnightly #193

Merged
merged 3 commits into from
Jun 30, 2020
Merged

Use light text theme for Fortnightly #193

merged 3 commits into from
Jun 30, 2020

Conversation

guidezpl
Copy link
Member

Always use light text theme as a base for Fortnightly to always render text in black

Before After
Screenshot 2020-06-30 at 11 26 10 Screenshot 2020-06-30 at 11 24 19

Copy link
Contributor

@perclasson perclasson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks like this increased the main.dart.js file with a few kb for whatever reason, might want to increase the benchmark in the test.

@guidezpl guidezpl merged commit 4482146 into master Jun 30, 2020
@guidezpl guidezpl deleted the fix-fortnightly-text branch June 30, 2020 11:02
DanTup pushed a commit to DanTup/flutter_gallery that referenced this pull request Jun 30, 2020
In the Shrine app, there used to be large gaps at the bottom of the screen.
This PR implements an algorithm that rearranges the order of cards so that the heights of the columns are closer, reducing the size of gaps.


Former-commit-id: 097211d
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants