Use a deterministic hashmap for reproducible builds #3445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4d12e4c to
ff2afa8
Compare
|
Good morning! Sorry for not getting back to you yesterday. I did trigger the CI for you, and it seems there's some build/clippy failures in the unit tests. Could you have a look at those? |
Signed-off-by: Andrea Manzini <ilmanzo@gmail.com>
ff2afa8 to
c99d5bd
Compare
roypat
approved these changes
Feb 16, 2023
There was a problem hiding this comment.
LGTM! The binary files produced are indeed identical across runs now:
$ for i in $(seq 100) ; do cargo run -p seccompiler -- --input-file resource/seccomp/unimplemented.json --target-arch x86_64 --output-file x > /dev/null ; md5sum x ; done | sort | uniq -c
100 ccf7c06d325fee897449f7a3a698a243 x
pb8o
approved these changes
Feb 16, 2023
|
Synced with @luminitavoicu off-line and decided to merge this as is. We'll have to do some changelog work before the release anyway, so we'll just add an entry when that happens |
roypat
added a commit
to roypat/firecracker
that referenced
this pull request
Feb 17, 2023
Added missing entries for 1.3 release - bchalios@'s net scatter-gather improvements (firecracker-microvm#2958) - seccompiler change to make builds reproducible (firecracker-microvm#3445) Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat
added a commit
to roypat/firecracker
that referenced
this pull request
Feb 17, 2023
Added missing entries for 1.3 release - bchalios@'s net scatter-gather improvements (firecracker-microvm#2958) - seccompiler change to make builds reproducible (firecracker-microvm#3445) Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat
added a commit
to roypat/firecracker
that referenced
this pull request
Feb 17, 2023
Added missing entries for 1.3 release - bchalios@'s net scatter-gather improvements (firecracker-microvm#2958) - seccompiler change to make builds reproducible (firecracker-microvm#3445) Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
jkrshnmenon
pushed a commit
to jkrshnmenon/firecracker
that referenced
this pull request
Mar 7, 2023
Added missing entries for 1.3 release - bchalios@'s net scatter-gather improvements (firecracker-microvm#2958) - seccompiler change to make builds reproducible (firecracker-microvm#3445) Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
JonathanWoollett-Light
pushed a commit
to JonathanWoollett-Light/firecracker
that referenced
this pull request
Mar 17, 2023
Added missing entries for 1.3 release - bchalios@'s net scatter-gather improvements (firecracker-microvm#2958) - seccompiler change to make builds reproducible (firecracker-microvm#3445) Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Replace HashMap usage in
seccompwith BTreeMap to preserve order of items.This enable reproducible builds (see issue #3439)
Reason
fixes #3439
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
CHANGELOG.md.TODOs link to an issue.rust-vmm.