[block] simplify unsafe flush behavior #2702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I did some manual tests and we get an improvement of roughly 2-3% |
dianpopa
previously approved these changes
Aug 23, 2021
georgepisaltu
previously approved these changes
Aug 23, 2021
6e65ada to
b594443
Compare
Leverage the VIRTIO_BLK_F_FLUSH flag in order to avoid receiving flush requests when the block device uses CacheType::Unsafe. This has 2 advantages: 1. It simplifies the request execution logic a bit 2. It improves efficiency when the block device uses CacheType::Unsafe Signed-off-by: Serban Iorga <seriorga@amazon.com>
b594443 to
60ea55a
Compare
dianpopa
approved these changes
Aug 23, 2021
georgepisaltu
approved these changes
Aug 23, 2021
ShadowCurse
added a commit
to ShadowCurse/firecracker
that referenced
this pull request
Oct 18, 2023
In firecracker-microvm#2702 the behaviour of the `Unsafe` cache type was changed. If selected the `flush` feature is not advertised to the guest. This commit just adds missing documentation change. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
added a commit
to ShadowCurse/firecracker
that referenced
this pull request
Oct 18, 2023
In firecracker-microvm#2702 the behaviour of the `Unsafe` cache type was changed. If selected the `flush` feature is not advertised to the guest. This commit just adds missing documentation change. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
added a commit
to ShadowCurse/firecracker
that referenced
this pull request
Oct 18, 2023
In firecracker-microvm#2702 the behaviour of the `Unsafe` cache type was changed. If selected the `flush` feature is not advertised to the guest. This commit just adds missing documentation change. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
added a commit
to ShadowCurse/firecracker
that referenced
this pull request
Oct 19, 2023
In firecracker-microvm#2702 the behaviour of the `Unsafe` cache type was changed. If selected the `flush` feature is not advertised to the guest. This commit just adds missing documentation change. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
added a commit
to ShadowCurse/firecracker
that referenced
this pull request
Oct 19, 2023
In firecracker-microvm#2702 the behaviour of the `Unsafe` cache type was changed. If selected the `flush` feature is not advertised to the guest. This commit just adds missing documentation change. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
added a commit
to ShadowCurse/firecracker
that referenced
this pull request
Oct 19, 2023
In firecracker-microvm#2702 the behaviour of the `Unsafe` cache type was changed. If selected the `flush` feature is not advertised to the guest. This commit just adds missing documentation change. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
added a commit
to ShadowCurse/firecracker
that referenced
this pull request
Oct 20, 2023
In firecracker-microvm#2702 the behaviour of the `Unsafe` cache type was changed. If selected the `flush` feature is not advertised to the guest. This commit just adds missing documentation change. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
added a commit
to ShadowCurse/firecracker
that referenced
this pull request
Oct 20, 2023
In firecracker-microvm#2702 the behaviour of the `Unsafe` cache type was changed. If selected the `flush` feature is not advertised to the guest. This commit just adds missing documentation change. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
added a commit
to ShadowCurse/firecracker
that referenced
this pull request
Oct 20, 2023
In firecracker-microvm#2702 the behaviour of the `Unsafe` cache type was changed. If selected the `flush` feature is not advertised to the guest. This commit just adds missing documentation change. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
added a commit
to ShadowCurse/firecracker
that referenced
this pull request
Oct 20, 2023
In firecracker-microvm#2702 the behaviour of the `Unsafe` cache type was changed. If selected the `flush` feature is not advertised to the guest. This commit just adds missing documentation change. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
added a commit
to ShadowCurse/firecracker
that referenced
this pull request
Oct 20, 2023
In firecracker-microvm#2702 the behaviour of the `Unsafe` cache type was changed. If selected the `flush` feature is not advertised to the guest. This commit just adds missing documentation change. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
added a commit
to ShadowCurse/firecracker
that referenced
this pull request
Oct 21, 2023
In firecracker-microvm#2702 the behaviour of the `Unsafe` cache type was changed. If selected the `flush` feature is not advertised to the guest. This commit just adds missing documentation change. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
added a commit
to ShadowCurse/firecracker
that referenced
this pull request
Oct 23, 2023
In firecracker-microvm#2702 the behaviour of the `Unsafe` cache type was changed. If selected the `flush` feature is not advertised to the guest. This commit just adds missing documentation change. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
added a commit
to ShadowCurse/firecracker
that referenced
this pull request
Oct 23, 2023
In firecracker-microvm#2702 the behaviour of the `Unsafe` cache type was changed. If selected the `flush` feature is not advertised to the guest. This commit just adds missing documentation change. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
added a commit
to ShadowCurse/firecracker
that referenced
this pull request
Oct 23, 2023
In firecracker-microvm#2702 the behaviour of the `Unsafe` cache type was changed. If selected the `flush` feature is not advertised to the guest. This commit just adds missing documentation change. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
added a commit
to ShadowCurse/firecracker
that referenced
this pull request
Oct 25, 2023
In firecracker-microvm#2702 the behaviour of the `Unsafe` cache type was changed. If selected the `flush` feature is not advertised to the guest. This commit just adds missing documentation change. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
added a commit
to ShadowCurse/firecracker
that referenced
this pull request
Oct 25, 2023
In firecracker-microvm#2702 the behaviour of the `Unsafe` cache type was changed. If selected the `flush` feature is not advertised to the guest. This commit just adds missing documentation change. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
added a commit
to ShadowCurse/firecracker
that referenced
this pull request
Oct 28, 2023
In firecracker-microvm#2702 the behaviour of the `Unsafe` cache type was changed. If selected the `flush` feature is not advertised to the guest. This commit just adds missing documentation change. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
added a commit
to ShadowCurse/firecracker
that referenced
this pull request
Oct 28, 2023
In firecracker-microvm#2702 the behaviour of the `Unsafe` cache type was changed. If selected the `flush` feature is not advertised to the guest. This commit just adds missing documentation change. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
added a commit
to ShadowCurse/firecracker
that referenced
this pull request
Oct 28, 2023
In firecracker-microvm#2702 the behaviour of the `Unsafe` cache type was changed. If selected the `flush` feature is not advertised to the guest. This commit just adds missing documentation change. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
added a commit
to ShadowCurse/firecracker
that referenced
this pull request
Oct 30, 2023
In firecracker-microvm#2702 the behaviour of the `Unsafe` cache type was changed. If selected the `flush` feature is not advertised to the guest. This commit just adds missing documentation change. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
added a commit
to ShadowCurse/firecracker
that referenced
this pull request
Oct 30, 2023
In firecracker-microvm#2702 the behaviour of the `Unsafe` cache type was changed. If selected the `flush` feature is not advertised to the guest. This commit just adds missing documentation change. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
added a commit
to ShadowCurse/firecracker
that referenced
this pull request
Oct 30, 2023
In firecracker-microvm#2702 the behaviour of the `Unsafe` cache type was changed. If selected the `flush` feature is not advertised to the guest. This commit just adds missing documentation change. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
added a commit
to ShadowCurse/firecracker
that referenced
this pull request
Oct 30, 2023
In firecracker-microvm#2702 the behaviour of the `Unsafe` cache type was changed. If selected the `flush` feature is not advertised to the guest. This commit just adds missing documentation change. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
added a commit
to ShadowCurse/firecracker
that referenced
this pull request
Oct 30, 2023
In firecracker-microvm#2702 the behaviour of the `Unsafe` cache type was changed. If selected the `flush` feature is not advertised to the guest. This commit just adds missing documentation change. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
added a commit
to ShadowCurse/firecracker
that referenced
this pull request
Oct 30, 2023
In firecracker-microvm#2702 the behaviour of the `Unsafe` cache type was changed. If selected the `flush` feature is not advertised to the guest. This commit just adds missing documentation change. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
added a commit
to ShadowCurse/firecracker
that referenced
this pull request
Oct 31, 2023
In firecracker-microvm#2702 the behaviour of the `Unsafe` cache type was changed. If selected the `flush` feature is not advertised to the guest. This commit just adds missing documentation change. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
added a commit
to ShadowCurse/firecracker
that referenced
this pull request
Oct 31, 2023
In firecracker-microvm#2702 the behaviour of the `Unsafe` cache type was changed. If selected the `flush` feature is not advertised to the guest. This commit just adds missing documentation change. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
added a commit
to ShadowCurse/firecracker
that referenced
this pull request
Nov 1, 2023
In firecracker-microvm#2702 the behaviour of the `Unsafe` cache type was changed. If selected the `flush` feature is not advertised to the guest. This commit just adds missing documentation change. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
added a commit
to ShadowCurse/firecracker
that referenced
this pull request
Nov 1, 2023
In firecracker-microvm#2702 the behaviour of the `Unsafe` cache type was changed. If selected the `flush` feature is not advertised to the guest. This commit just adds missing documentation change. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
added a commit
to ShadowCurse/firecracker
that referenced
this pull request
Nov 1, 2023
In firecracker-microvm#2702 the behaviour of the `Unsafe` cache type was changed. If selected the `flush` feature is not advertised to the guest. This commit just adds missing documentation change. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
added a commit
to ShadowCurse/firecracker
that referenced
this pull request
Nov 6, 2023
In firecracker-microvm#2702 the behaviour of the `Unsafe` cache type was changed. If selected the `flush` feature is not advertised to the guest. This commit just adds missing documentation change. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
added a commit
to ShadowCurse/firecracker
that referenced
this pull request
Nov 7, 2023
In firecracker-microvm#2702 the behaviour of the `Unsafe` cache type was changed. If selected the `flush` feature is not advertised to the guest. This commit just adds missing documentation change. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
added a commit
to ShadowCurse/firecracker
that referenced
this pull request
Nov 7, 2023
In firecracker-microvm#2702 the behaviour of the `Unsafe` cache type was changed. If selected the `flush` feature is not advertised to the guest. This commit just adds missing documentation change. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
added a commit
to ShadowCurse/firecracker
that referenced
this pull request
Nov 7, 2023
In firecracker-microvm#2702 the behaviour of the `Unsafe` cache type was changed. If selected the `flush` feature is not advertised to the guest. This commit just adds missing documentation change. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
added a commit
to ShadowCurse/firecracker
that referenced
this pull request
Nov 7, 2023
In firecracker-microvm#2702 the behaviour of the `Unsafe` cache type was changed. If selected the `flush` feature is not advertised to the guest. This commit just adds missing documentation change. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
added a commit
that referenced
this pull request
Nov 8, 2023
In #2702 the behaviour of the `Unsafe` cache type was changed. If selected the `flush` feature is not advertised to the guest. This commit just adds missing documentation change. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for This PR
[block] simplify unsafe flush behavior
Description of Changes
Leverage the VIRTIO_BLK_F_FLUSH flag in order to avoid receiving flush
requests when the block device uses CacheType::Unsafe. This has 2
advantages:
rust-vmm.License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.
PR Checklist
[Author TODO: Meet these criteria.][Reviewer TODO: Verify that these criteria are met. Request changes if not]git commit -s).unsafecode is properly documented.firecracker/swagger.yaml.CHANGELOG.md.