Skip to content

Use typed client from Keda instead of unstructured #2989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 14, 2024
Merged

Use typed client from Keda instead of unstructured #2989

merged 5 commits into from
Aug 14, 2024

Conversation

soharab-ic
Copy link
Contributor

@soharab-ic soharab-ic commented Aug 13, 2024 •
edited
Loading

Description

Which issue(s) this PR fixes:

Fixes #

Testing

  • Tried this kafka-keda example.
  • Created 100 MQTs with Kafka-keda and verified that scaledobjects.keda.sh resource was created and trigger processing was working.
  • Could not try this kafka-keda-sasl example since it requires Confluent cloud based Kafka cluster in this example. Tried this example with incorrect secret parameters and verified that triggerauthentications.keda.sh resource was created.
  • With Kafka-Keda, recently added metrics fission_mqt_inprocess and fission_mqt_status are available and working as expected. Please check attachment
    metrics.docx

Checklist:

  • I ran tests as well as code linting locally to verify my changes.
  • I have done manual verification of my changes, changes working as expected.
  • I have added new tests to cover my changes.
  • My changes follow contributing guidelines of Fission.
  • I have signed all of my commits.

@soharab-ic
Use typed client for Keda
05920f6 
Signed-off-by: Md Soharab Ansari <soharab.ansari@infracloud.io>
@soharab-ic
Downgraded apimachinery version to v0.30.0 because of compilation error
34384dd 
Signed-off-by: Md Soharab Ansari <soharab.ansari@infracloud.io>
@soharab-ic
Upgrade golanggci-lint version to v1.57.0
63c7074 
Signed-off-by: Md Soharab Ansari <soharab.ansari@infracloud.io>
@soharab-ic
Skip cache for golanggci-lint-action
7a20157 
Signed-off-by: Md Soharab Ansari <soharab.ansari@infracloud.io>
@soharab-ic
grpc.WithBlock is deprecated
ad1ea6e 
Signed-off-by: Md Soharab Ansari <soharab.ansari@infracloud.io>
@codecov Codecov
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 34.66667% with 49 lines in your changes missing coverage. Please review.

Project coverage is 44.49%. Comparing base (c6beb29) to head (ad1ea6e).

Files Patch % Lines
pkg/mqtrigger/scalermanager.go 32.87% 49 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2989      +/-   ##
==========================================
+ Coverage   44.47%   44.49%   +0.01%     
==========================================
  Files         236      236              
  Lines       24542    24528      -14     
==========================================
- Hits        10916    10913       -3     
+ Misses      12217    12206      -11     
  Partials     1409     1409
Flag Coverage Δ
unittests 44.49% <34.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanketsudake sanketsudake merged commit 0b9d4c6 into main Aug 14, 2024
10 checks passed
@sanketsudake sanketsudake deleted the keda-typed-client branch September 26, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanketsudake sanketsudake sanketsudake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soharab-ic @sanketsudake